Problem/Motivation

Follow-up of #2795567: Use Symfony's VarDumper for easier test debugging with dump().

AssertLegacyTrait::verbose is leftover of Simpletest where it was dumping some content in the Simpletest result UI, but in PHPUnit it is actually doing nothing. After #2795567: Use Symfony's VarDumper for easier test debugging with dump(), dump() can be used in cases where it's necessary to debug output to the CLI results.

Steps to reproduce

Deprecate the method and remove its usage.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3193163-2.patch26.88 KBmondrake

Issue fork drupal-3193163

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
FileSize
3193163-2.patch26.88 KB
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Issue tags: +Deprecated assertions
mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Postponed » Needs work
Issue tags: +Needs change record, +Needs tests

Parent was committed

mondrake opened merge request !304

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Issue tags: -Needs tests
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

We should probably close #2875038: AssertLegacyTrait::verbose() doesn't do anything as won't fix or duplicate of this.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Related issues: +#2875038: AssertLegacyTrait::verbose() doesn't do anything

#7 aw I forgot about that one. I guess we should credit here those working on that one before closing it.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs work » Needs review
Issue tags: -Needs change record

Added CR.

In the process, also AssertMailTrait::verboseEmail(), that is calling verbose() but has no use in Core any more, was deprecated too.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Needs work

Two now-incorrect docblocks but otherwise this is looking ready to go.

Looks possible that we can now deprecate executeView() itself and just call it on the view object directly, but definitely out of scope for here.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs work » Needs review

Thanks @longwave

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

LGTM.

@core committers please see #8 and credit contributors from the linked issue.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed 33700d0 and pushed to 9.2.x. Thanks!

This is really nice tidy up.

  • alexpott committed 33700d0 on 9.2.x 
    Issue #3193163 by mondrake, longwave: Deprecate AssertLegacyTrait::...

mondrake closed merge request !304

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.