Problem/Motivation

MigrationInterface has an @see referring to a load plugin that was removed in #2549013: Remove load plugins in August 2015.

Proposed resolution

Make a patch or MR to remove the @see, a replacement @see is not needed.

Remaining tasks

Patch
Review
Commit

CommentFileSizeAuthor
#3 removed-load-reference-3192888-3.patch611 bytesbaliram.patil
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Title: Remove reference to removed method » Remove reference to load plugin, LoadEntity
baliram.patil’s picture

baliram.patil CreditAttribution: baliram.patil as a volunteer and at Asentech LLC commented
FileSize
removed-load-reference-3192888-3.patch611 bytes

I have removed reference of load plugin from MigrationInterface.

baliram.patil’s picture

baliram.patil CreditAttribution: baliram.patil as a volunteer and at Asentech LLC commented
Status: Active » Needs review
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@baliram.patil, thanks!

Without the patch a grep finds two instances of LoadEntity

$ grep -r LoadEntity core
core/tests/Drupal/KernelTests/Core/Entity/EntityLoadByUuidTest.php:  public function testLoadEntityByUuidAccessChecking() {
core/modules/migrate/src/Plugin/MigrationInterface.php:   * @see Drupal\migrate_drupal\Plugin\migrate\load\LoadEntity::processLinkField()

and with the patch only one

$ grep -r LoadEntity core
core/tests/Drupal/KernelTests/Core/Entity/EntityLoadByUuidTest.php:  public function testLoadEntityByUuidAccessChecking() {

And tests are still passing.

  • catch committed e6d54ea on 9.2.x 
    Issue #3192888 by baliram.patil, quietone: Remove reference to load...

  • catch committed 00d2cbf on 9.1.x 
    Issue #3192888 by baliram.patil, quietone: Remove reference to load...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.