Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
AssertLegacyTrait::assertNotIdentical() is deprecated in drupal:8.0.0 and is removed from drupal:10.0.0. Use $this->assertNotSame() instead. See https://www.drupal.org/node/3129738
Proposed resolution
Replace usages.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3191986
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3191986-replace-usages-of
changes, plain diff MR !240
1 hidden branch
Comments
Comment #3
mondrakeComment #4
daffie CreditAttribution: daffie commentedAll the code changes look good to me.
All instances of
assertNotIdentical()have been replaced withassertNotSame().In places where it is very clear what the expected result is, the expected result has become the first parameter.
There is a deprecation message test added.
For me it is RTBC.
Comment #5
mondrakeComment #7
catchCommitted c2e91dc and pushed to 9.2.x. Thanks!
Didn't backport to 9.1.x since it's removing the deprecation suppression from the list. We could potentially backport it without that (and the test coverage) to keep tests in sync, but also this isn't a massive patch so shouldn't result in too many conflicts.