Problem/Motivation

PHPUnit\Framework\Exception: PHP Deprecated: Required parameter $expected follows optional parameter $langcode in /var/www/html/modules/contrib/pathauto/tests/src/Functional/PathautoTestHelperTrait.php on line 172

Proposed resolution

Make $langcode required. I could only find one occurrence of the assertion call, and already defined the $langcode parameter.

Remaining tasks

Commit.

User interface changes

None

API changes

Only for tests using the PathautoTestHelperTrait::assertEntityPattern() method.

Data model changes

None

CommentFileSizeAuthor
#2 3187744-pathauto-PathautoTestHelperTrait-fix-php8-2.patch589 bytespenyaskito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Issue summary: View changes
Status: Active » Needs review
FileSize
3187744-pathauto-PathautoTestHelperTrait-fix-php8-2.patch589 bytes

Make $langcode required. I could only find one occurrence of the assertion call, and already defined the $langcode parameter.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Priority: Normal » Major

I'm guessing HEAD broken should be critical, but as it's only in php8 marking as major.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Thanks, committed.

  • Berdir committed 43c8079 on 8.x-1.x authored by penyaskito 
    Issue #3187744 by penyaskito: PathautoTestHelperTrait deprecation with...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.