Problem/Motivation

The TermTranslation migrate source plugin defines usage of I18nQueryTrait, but it does not actually use that trait.

Proposed resolution

Remove "I18nQueryTrait" from the "TermTranslation" migrate source plugin.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 core-remove_unused_i18nquerytrait_from_termtranslation-3187477-2.patch644 byteshuzooka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
CreditAttribution: huzooka at Cheppers for Acquia commented
FileSize
core-remove_unused_i18nquerytrait_from_termtranslation-3187477-2.patch644 bytes
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
CreditAttribution: huzooka at Cheppers for Acquia commented
Assigned: huzooka » Unassigned
Status: Active » Needs review
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Trivial patch of the month

👏🚢

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented

@huzooka, you keep fixing my errors! ;-) Thx.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

The class was added this way in #3035392: Migrate vocabulary translations and taxonomy term references for Drupal 7 node translations and it has never used the \Drupal\content_translation\Plugin\migrate\source\I18nQueryTrait::getPropertyNotInRowTranslation() method.

Committed f32390f and pushed to 9.2.x. Thanks!

As a minor bug - it's v tasky - only committed to 9.2.x.

  • alexpott committed f32390f on 9.2.x 
    Issue #3187477 by huzooka: Remove unused "I18nQueryTrait" from "...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.