Remove use of concatenated t() in assertions

I also missed quite a few

core/modules/field_ui/tests/src/Functional/ManageDisplayTest.php:    $this->verbose(t('Rendered node - view mode: @view_mode', ['@view_mode' => $view_mode]) . '<hr />' . $output);
core/modules/update/tests/src/Functional/UpdateContribTest.php:    $this->assertRaw('<div class="project-update__status">' . t('Failed to get available update data'));
core/modules/update/tests/src/Functional/UpdateCoreTest.php:    $this->assertNoRaw('<li>' . t('There is a security update available for your version of Drupal.'));
core/modules/locale/tests/src/Functional/LocaleUpdateInterfaceTest.php:    $update_button = $this->xpath('//input[@type="submit"][@value="' . t('Update translations') . '"]');
core/modules/content_translation/tests/src/Functional/ContentTranslationUITestBase.php:    return t('Save') . $this->getFormSubmitSuffix($entity, $langcode);
core/modules/file/tests/src/Functional/SaveUploadTest.php:    $message = t('Only files with the following extensions are allowed:') . ' <em class="placeholder">' . $extensions . '</em>';
core/modules/file/tests/src/Functional/SaveUploadTest.php:    $message = t('For security reasons, your upload has been renamed to') . ' <em class="placeholder">' . $this->phpfile->filename . '_.txt' . '</em>';
core/modules/file/tests/src/Functional/SaveUploadTest.php:    $message = t('For security reasons, your upload has been renamed to') . ' <em class="placeholder">' . $this->phpfile->filename . '_.txt' . '</em>';
core/modules/file/tests/src/Functional/SaveUploadTest.php:    $message = t('Only files with the following extensions are allowed:') . ' <em class="placeholder">' . $edit['extensions'] . '</em>';
core/modules/file/tests/src/Functional/SaveUploadTest.php:    $message = t('Only files with the following extensions are allowed:') . ' <em class="placeholder">' . $edit['extensions'] . '</em>';
core/modules/file/tests/src/Functional/SaveUploadFormTest.php:    $message = t('Only files with the following extensions are allowed:') . ' <em class="placeholder">' . $extensions . '</em>';
core/modules/file/tests/src/Functional/SaveUploadFormTest.php:    $message = t('For security reasons, your upload has been renamed to') . ' <em class="placeholder">' . $this->phpfile->filename . '_.txt' . '</em>';
core/modules/file/tests/src/Functional/SaveUploadFormTest.php:    $this->assertRaw(t('One or more files could not be uploaded.') . '<div class="item-list">');
core/modules/views/tests/src/Kernel/ModuleTest.php:    $description_top = '<p>' . t('The handler for this item is broken or missing. The following details are available:') . '</p>';
core/modules/views/tests/src/Kernel/ModuleTest.php:    $description_bottom = '<p>' . t('Enabling the appropriate module may solve this issue. Otherwise, check to see if there is a module update available.') . '</p>';
core/tests/Drupal/KernelTests/Core/Entity/Element/EntityAutocompleteElementFormTest.php:    $expected = t('- Restricted access -') . ' (' . $this->referencedEntities[0]->id() . ')';
core/tests/Drupal/KernelTests/Core/Entity/Element/EntityAutocompleteElementFormTest.php:    $expected .= ', ' . t('- Restricted access -') . ' (' . $this->referencedEntities[1]->id() . ')';

1. +++ b/core/modules/file/tests/src/Functional/SaveUploadFormTest.php
   @@ -166,7 +166,7 @@ public function testHandleExtension() {
   +    $message = 'Only files with the following extensions are allowed: <em class="placeholder">' . $extensions . '</em>';
        $this->assertRaw($message);
   

   I think we should inline the variable in this test and SaveUploadTest.

2. +++ b/core/tests/Drupal/KernelTests/Core/Entity/Element/EntityAutocompleteElementFormTest.php
   @@ -336,10 +336,10 @@ public function testEntityAutocompleteAccess() {
   +    $expected = '- Restricted access - (' . $this->referencedEntities[0]->id() . ')';
        $this->assertEqual($form['single_access']['#value'], $expected);
   ...
   +    $expected .= ', - Restricted access - (' . $this->referencedEntities[1]->id() . ')';
        $this->assertEqual($form['tags_access']['#value'], $expected);
   

   Again we can just inline the variable here.

There are more instances of:

     $this->assertRaw($message);

I think we should inline all the ones changed in SaveUploadTest in this patch.

Re #12 I also think doing those conversions here is worthwhile, I guess this is a small enough patch to try it here and see if core committers agree? If we do do this, we should only touch lines that would be touched by the patch anyway, no matter how tempting it is to scope creep into the next line even if it seems trivial.

Addressed #10-#13. No interdiff as pretty much every line has changed again.

I think I am perhaps taking liberties with this, but it's a good a time as any to do it:

     // Make sure duplicate messages don't appear on Update status pages.
     $this->drupalGet('admin/reports/status');
-    // We're expecting "There is a security update..." inside the status report
-    // itself, but the message from
-    // \Drupal\Core\Messenger\MessengerInterface::addStatus() appears as an li
-    // so we can prefix with that and search for the raw HTML.
-    $this->assertNoRaw('<li>' . t('There is a security update available for your version of Drupal.'));
+    $this->assertSession()->pageTextContainsOnce('There is a security update available for your version of Drupal.');

#17 does not apply.

Addressed #16 from #15.

Uploaded the wrong files, let's try again.