Problem/Motivation

The linkit field description is

"Start typing to find content."

When you have an email matcher, which adds the ability to to add mailto links, the description should reflect this.

Proposed resolution

Update code to check for email matcher. If present then update description to something like

Start typing to find content. For mailto link, type the complete email address.

Issue fork linkit-3184082

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

iStryker created an issue. See original summary.

iStryker’s picture

Status: Active » Needs review
Pooja Ganjage’s picture

FileSize
635 bytes

Hi,

Creating a patch for this issue.

Please review the patch.

Thanks.

iStryker’s picture

@Pooja see the merge request. It should only change if email matcher is enabled/on

Pooja Ganjage’s picture

FileSize
1.9 KB

Creating a patch as per the given merged request by @iStryker.

Pooja Ganjage’s picture

FileSize
1.9 KB
anon’s picture

Status: Needs review » Needs work

A test for this would be appreciated

Liam Morland’s picture

In the patch in #7, it looks like continue should be break.

Pooja Ganjage’s picture

FileSize
1.88 KB

Updated Patch.

Pooja Ganjage’s picture

Status: Needs work » Needs review

stefanos.petrakis made their first commit to this issue’s fork.

stefanos.petrakis@gmail.com’s picture

Refactoring into sth a bit more compact, the previous one would work fine as well, there was no need for the $email_matcher variable was my main objection.

@anon: I will try to prepare a test for this case. Soonish.

Liam Morland’s picture

In this one there is an extra call to t().

stefanos.petrakis@gmail.com’s picture

FileSize
3.43 KB

Here are the tests for this case, should fail.

Status: Needs review » Needs work

The last submitted patch, 15: 3184082-tests-15.patch, failed testing. View results

stefanos.petrakis@gmail.com’s picture

Status: Needs work » Needs review

And setting this back to "Needs review" now that tests, including the new ones, are green.