Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
The linkit field description is
"Start typing to find content."
When you have an email matcher, which adds the ability to to add mailto links, the description should reflect this.
Proposed resolution
Update code to check for email matcher. If present then update description to something like
Start typing to find content. For mailto link, type the complete email address.
Comment | File | Size | Author |
---|
Issue fork linkit-3184082
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
iStryker CreditAttribution: iStryker commentedComment #4
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedHi,
Creating a patch for this issue.
Please review the patch.
Thanks.
Comment #5
iStryker CreditAttribution: iStryker commented@Pooja see the merge request. It should only change if email matcher is enabled/on
Comment #6
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedCreating a patch as per the given merged request by @iStryker.
Comment #7
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #8
anonA test for this would be appreciated
Comment #9
Liam MorlandIn the patch in #7, it looks like
continue
should bebreak
.Comment #10
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedUpdated Patch.
Comment #11
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #13
stefanos.petrakis@gmail.comRefactoring into sth a bit more compact, the previous one would work fine as well, there was no need for the $email_matcher variable was my main objection.
@anon: I will try to prepare a test for this case. Soonish.
Comment #14
Liam MorlandIn this one there is an extra call to t().
Comment #15
stefanos.petrakis@gmail.comHere are the tests for this case, should fail.
Comment #17
stefanos.petrakis@gmail.comAnd setting this back to "Needs review" now that tests, including the new ones, are green.