Problem/Motivation

Automated tests are failing on unrelated patches (#3042661: Drupal 9 Deprecated Code Report, #3182867: Remove unused use statements) seemingly due to an incompatibility with config_filter 2.x:

So that confirms that the issue is related to the version of config_filter being used during the test. It seems like the test is written in a way that only seems to work with config_filter 1.x.

Steps to reproduce

Submit a patch for testing.

Proposed resolution

Refactor the failing test to make it compatible with both config_filter 1.x and 2.x.

CommentFileSizeAuthor
#9 3182999-9.patch18.18 KBbircher
#7 3182999-7.patch17.52 KBbircher
#5 3182999-5.patch16.87 KBbircher
#2 3182999-2.patch16.56 KBbircher
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markdorison created an issue. See original summary.

bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher as a volunteer and at Nuvole for World Food Programme commented
FileSize
3182999-2.patch16.56 KB

lets see if this fixes it.

In addition I also added a whole bunch of new tests, the kind I am interested in to test different scenarios easily. I hope it will make it easier for people to cover their cases. Then we can also add them to 3.x and fix the 3.x branch finally too.

bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher as a volunteer and at Nuvole for World Food Programme commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3182999-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher as a volunteer and at Nuvole for World Food Programme commented
Status: Needs work » Needs review
FileSize
3182999-5.patch16.87 KB

Status: Needs review » Needs work

The last submitted patch, 5: 3182999-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher as a volunteer and at Nuvole for World Food Programme commented
Status: Needs work » Needs review
FileSize
3182999-7.patch17.52 KB

third time is the charm?

Status: Needs review » Needs work

The last submitted patch, 7: 3182999-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher as a volunteer and at Nuvole for World Food Programme commented
Status: Needs work » Needs review
FileSize
3182999-9.patch18.18 KB

So that last one failed because that was a legitimate bug in the code.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented

@bircher At least we know the tests work! Nice!

  • bircher committed 2f5d218 on 8.x-2.x 
    Issue #3182999 by bircher: Automated tests failing due to config_filter...
bircher’s picture

bircher
Location 🇨🇿
CreditAttribution: bircher as a volunteer and at Nuvole for World Food Programme commented
Status: Needs review » Fixed

nice, so now we can go back and fix things.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.