Fix typo in FileStorage error message

I'm guessing we don't have tests for this, so given this is a bug, we should probably add one

We already have \Drupal\KernelTests\Core\Config\Storage\FileStorageTest::testReadUnsupportedDataTypeConfigException which is covering that code path, so we could probably modify it to cover the actual message

Thanks for this

Test added.

+++ b/core/tests/Drupal/KernelTests/Core/Config/Storage/FileStorageTest.php
@@ -73,17 +73,15 @@ public function testlistAll() {
+   * Tests UnsupportedDataTypeConfigException.
...
   public function testReadUnsupportedDataTypeConfigException() {

Let the method name inline with the comment.

Trying to fix the failed test.

Another try

Help needed, the expected error messages are different between local and CI.

There are at least two possible YAML parsers - there is a PECL extension (which it looks like DrupalCI has enabled), and the Symfony Yaml component. They have slightly different error messages.

I think you might have to catch the exception and use assertStringContainsString on the exception message like the original test did.

In fact there is a simpler way.

#12, make sense, thanks, @longwave!

+++ b/core/tests/Drupal/KernelTests/Core/Config/Storage/FileStorageTest.php
@@ -73,17 +73,15 @@ public function testlistAll() {
-      $this->assertStringContainsString($this->storage->getFilePath('core.extension'), $e->getMessage(), 'Erroneous file path is displayed.');
...
+    $this->expectExceptionMessageMatches("@Invalid data type in config $name, found in file $path: @");

Although not the whole error message gets asserted, it is better than the original.

Committed/pushed to 9.2.x, and cherry-picked to 9.1.x and 8.9.x, thanks!

The version change didn’t quite stick everywhere due to some race condition. Just updating to flush that out.

Reverted from 8.9.x as this change broke tests there.

I think the problem is caused by different symfony yaml version in D8/D9.