The same path alias cannot be set for two languages

Thanks for reporting and thanks for working on this.

Moving this to the Drupal core version that is currently receiving bug fixes.

We will need an automated test to demonstrate this issue occurs in a clean Drupal install and the fix needs work because it is currently failing a fair number of tests.

Re-roll patch for 9.1.x.

Fixed the phpcs issue.

Fixing fail tests.

The following patch file is working fine for me

The following patch file is working fine in drupal 8.9.x

https://www.drupal.org/files/issues/2021-06-07/path_alias.patch

command related issues are fixed

fixed fail tests

changes are modified to support both 8.9 and 9

Fixing fail tests.

Fixing fail tests.

+    $langcode_ = $form_values['langcode'][0]['value'];

We don't use variable names ending with an underscore.

+    if ($aliasStatus == 'node') {
+      $langcode = $element['langcode']['#value'];
+    }

$aliasStatus isn't a self-descriptive name. Is really necessary to check if the path alias is for a node? The same issue would be present whether the path alias is for a different entity.

-        'langcode' => $element['langcode']['#value'],
+        'langcode' => $langcode,
+        // 'langcode' => $element['langcode']['#value'],

There is no need to show the previous code as commented line.

Drupal 7:

User have a choice to create multi-language pages in any content type.

Ex : en/demo.html - 'Article' content-type and jp/demo.html in 'Basic page' content-type - its possible and it works

Drupal 8 and 9 :

User don't have a choice and should must create multi-language pages in same content-type of source language.

Ex : /en/demo.html - 'Article' content-type and /jp/demo.html in 'Basic page' content-type - its not possible

+++ b/core/modules/path/src/Plugin/Field/FieldWidget/PathWidget.php
@@ -83,7 +83,12 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen
+    $otherAlias = \Drupal::service('path_alias.manager')->getPathByAlias($alias, $form_values['langcode'][0]['value']);

Local variable names should be in camel case.

Also the service should be injected.

Also, as noted already, needs a test.

Hey @joachim thanks for the review!

1. Local variable names should be in camel case. Done! Changed the variable to be snake_case
2. Also the service should be injected. Regarding this point, are you sure we should inject the service in this scenario? The function validateFormElement is static
3. This still needs a test, so I'll leave this as NW.

> The function validateFormElement is static

Oh, whoops. You're right, it can't be injected into a static!

Thanks for the fix!

Updating issue summary with some details and slightly reordering steps to what makes sense.

Thanks for IS update @klonos, with that information I was able to create a test and replicate the bug. Here's a new patch, and a test-only patch.

Nice work @murilohp

+++ b/core/modules/path/tests/src/Functional/PathLanguageTest.php
@@ -212,4 +212,32 @@ public function testAliasTranslation() {
+    $this->assertSession()->pageTextContains('Basic page ' . $edit['title[0][value]'] . ' has been created.');

I don't really like this as a way of verifying the outcome here. I'd prefer to see something that proves more explicitly that we really have 2 nodes with the correct different paths.

Otherwise RTBC.

Re-roll patch #48 and apply changes #50

Hey! Thanks for the review @jonathanshaw! I've updated the test, now, the test will test,validate the page and also asserts the path alias.

@Nikhil_110, thanks for the patch, but I didn't get what you've done, you basically changed an unrelated test, so this new patch is based on #48.

+++ b/core/modules/path/src/Plugin/Field/FieldWidget/PathWidget.php
@@ -83,7 +83,12 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen
+    $other_alias = \Drupal::service('path_alias.manager')->getPathByAlias($alias, $form_values['langcode'][0]['value']);

This could do with a comment to explain what it's doing.

Currently it looks like it's part of the 'Trim...' code.