Problem/Motivation

#2907863: Prefer HTTPS protocol over HTTP when fetching translations was supposed to ensure we always use HTTPS to talk to ftp.d.o for translations.
However, it missed a spot.
We found it during #1538118: Update status does not verify the identity or authenticity of the release history URL, but it's really out of scope for that issue.
So I'm opening this issue to track that change, instead.

Steps to reproduce

Grep the code for 'http://ftp.drupal.org' and find this spot.

Proposed resolution

Use HTTPS.

Remaining tasks

  1. Upload the fix.
  2. Discuss if it needs test coverage.
  3. If so, add it.
  4. Reviews / refinements.
  5. Commit

User interface changes

API changes

Data model changes

Release notes snippet

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dww created an issue. See original summary.

dww’s picture

Status: Active » Needs review
Issue tags: +Bug Smash Initiative
FileSize
899 bytes
tedbow’s picture

Status: Needs review » Reviewed & tested by the community

Looks good! Thanks @dww

I don't think this change needs test

dww’s picture

Issue summary: View changes

Great, thanks! Updating remaining tasks accordingly. ;)

alexpott’s picture

Title: Always use HTTPS for fetching translations » [backport] Always use HTTPS for fetching translations
Version: 9.2.x-dev » 9.0.x-dev

Committed and pushed 79f9e9dc97 to 9.2.x and a1d2ad6edf to 9.1.x. Thanks!

  • alexpott committed 79f9e9d on 9.2.x
    Issue #3179318 by dww: Always use HTTPS for fetching translations
    

  • alexpott committed a1d2ad6 on 9.1.x
    Issue #3179318 by dww: Always use HTTPS for fetching translations
    
    (...
dww’s picture

Not sure how far back you want this backported, but #2 applies cleanly to 9.0.x. Here's a patch for 8.9.x.

Thanks!
-Derek

alexpott’s picture

Title: [backport] Always use HTTPS for fetching translations » Always use HTTPS for fetching translations
Version: 9.0.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

@xjm okayed the backport. Backported to 8.9.x

  • alexpott committed cc04c0e on 9.0.x
    Issue #3179318 by dww: Always use HTTPS for fetching translations
    
    (...

  • alexpott committed c6bb904 on 8.9.x
    Issue #3179318 by dww: Always use HTTPS for fetching translations
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.