Problem/Motivation

While reviewing #3112432: Prevent core, stub simpletest module from being installed on new sites for the release notes I noticed a typo in the message:
SimpleTest is has been removed from Drupal 9.0.0

A similar typo occurs a few other places in core; however, this is the only one that is a string change and is only relevant to 9.1.x. If we can address it before 9.1.0-beta1, we don't need to treat it as a string break

Proposed resolution

Attached fixes the typo.

User interface changes

No more typo in the requirements error when a user tries to enable Simpletest.

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#7 Screen Shot 2020-10-20 at 2.40.58 PM.png59.17 KBKristen Pol
#7 Screen Shot 2020-10-20 at 2.37.17 PM.png60.57 KBKristen Pol
#5 simpletest-3178037-5.patch1.08 KBxjm
#2 simpletest-deprecation-typo.patch0 bytesxjm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Active » Needs review
FileSize
simpletest-deprecation-typo.patch0 bytes
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Related issues: +#3178039: Correct typo "is has" in a few code comments and tests in core

Filed #3178039: Correct typo "is has" in a few code comments and tests in core for the rest of 'em.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 for Hook 42 commented

Maybe my computer is mucked but I get a blank file when going to that patch.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
FileSize
simpletest-3178037-5.patch1.08 KB

Uh, reuploading... I blame the internet.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 for Hook 42 commented

1. New patch looks good.

2. Patch addresses the issue in the issue summary and does not change anything else.

3. Issue summary is clear and complete.

4. I assume manual testing is not needed as this is a trivial text change.

5. If tests pass, then IMO this is RTBC.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 for Hook 42 commented
Issue tags: +Bug Smash Initiative
FileSize
Screen Shot 2020-10-20 at 2.37.17 PM.png60.57 KB
Screen Shot 2020-10-20 at 2.40.58 PM.png59.17 KB

I manually tested for good measure, and tagged for Bug Smash Initiative.

Before:

After:

pameeela’s picture

pameeela CreditAttribution: pameeela commented
Status: Needs review » Reviewed & tested by the community

Green so RTBC :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Title: Fix typo "is has" in SimpleTest deprecation warning » [backport] Fix typo "is has" in SimpleTest deprecation warning

Committed da115f6 and pushed to 9.2.x. Thanks!

Will backport to 9.1.x after alpha.

  • alexpott committed da115f6 on 9.2.x 
    Issue #3178037 by xjm, Kristen Pol: Fix typo "is has" in SimpleTest...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Title: [backport] Fix typo "is has" in SimpleTest deprecation warning » Fix typo "is has" in SimpleTest deprecation warning
Status: Reviewed & tested by the community » Fixed

  • alexpott committed 3e833a0 on 9.1.x 
    Issue #3178037 by xjm, Kristen Pol: Fix typo "is has" in SimpleTest...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.