Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
From @lauriii in #216 in #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta
+++ b/core/themes/olivero/templates/includes/preload.twig
@@ -0,0 +1,7 @@
+{#
+ Preload the fonts for the headings and normal body copy (non bold and non italic).
+ #}
This should be converted to @file documentation and should include variables passed for the template.
Comment | File | Size | Author |
---|---|---|---|
#13 | interdiff_10_13.txt | 545 bytes | anmolgoyal74 |
#13 | 3176910-13.patch | 1.76 KB | anmolgoyal74 |
#10 | interdiff_6-10.txt | 514 bytes | kishor_kolekar |
#10 | 3176910-10.patch | 1.79 KB | kishor_kolekar |
#6 | 3176910-6.patch | 1.78 KB | kostyashupenko |
Comments
Comment #2
mherchelComment #3
mherchelComment #4
hansa11 CreditAttribution: hansa11 as a volunteer and at Axelerant commentedPlease review.
Thanks!
Comment #5
mherchelThis file will also contain all the variables passed down from html.html.twig.
We could use the
only
keyword (see https://twig.symfony.com/doc/2.x/tags/include.html) to only pass theolivero_path
variable.Also, while you're modifying this, can you add the
olivero_path
variable to html.html.twig? It's missing from there.Comment #6
kostyashupenkoBy the way, why we don't declare woff fonts on preload, but only woff2 ? Wondering if issues in IE browser
Comment #8
mherchelThis should say "Returns the path to the Olivero theme." (replace "an" with "the", and add a period)
Comment #9
kishor_kolekar CreditAttribution: kishor_kolekar as a volunteer and at QED42 for Drupal India Association commentedComment #10
kishor_kolekar CreditAttribution: kishor_kolekar as a volunteer and at QED42 for Drupal India Association commentedWorked on comment #8
Comment #11
mherchel#11 looks great!
Comment #12
lauriiiAccording to our coding standards, the file summary should be one line of up to 80 characters ending in "."
Comment #13
anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commentedComment #14
mherchel#13 looks perfect!
Comment #17
lauriiiCommitted 2108025 and pushed to 9.2.x and 9.1.x. Thanks!