Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
FILE: /home/paulocs/AmbienteTeste/Drupal9.0/drupal-dev-oficial/web/core/modules/workspaces/workspaces.install
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
42 | WARNING | Unused variable $revision_metadata_keys.FILE: /home/paulocs/AmbienteTeste/Drupal9.0/drupal-dev-oficial/web/core/modules/workspaces/src/EntityQuery/Tables.php
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
66 | WARNING | Unused variable $active_workspace_id.Proposed resolution
Remove unused variables and figure why they were inserted.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 31744182-2.patch | 1.6 KB | paulocs |
Comments
Comment #2
paulocsA patch for it.
Comment #3
paulocs$active_workspace_id was added in issue https://www.drupal.org/project/drupal/issues/2784921. It is okay to remove it because they insert this variable maybe to make the code easier to read which makes no sense because
$this->sqlQuery->getMetaData('active_workspace_id')is already okay to understand.$revision_metadata_keys was added in issue https://www.drupal.org/project/drupal/issues/3062434 and it is okay because after https://www.drupal.org/project/drupal/issues/3099789
was committed, the variable stopped to be used.
Comment #4
adhershmnair CreditAttribution: adhershmnair as a volunteer and at Zyxware Technologies commentedI have reviewed the Patch #2.
$revision_metadata_keysand$active_workspace_idare unused variables as mentioned in #3.Patch Applied cleanly.
Thanks for checking the history.
RTBC.!
Comment #6
catchCommitted b90b27a and pushed to 9.1.x. Thanks!