Problem/Motivation

In core/modules/system/tests/src/Functional/File/ConfigTest.php, $file_path variable never used.

CommentFileSizeAuthor
#2 3173976-2.patch627 bytesshetpooja04
#2 file_path.png464.31 KBshetpooja04
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shetpooja04 created an issue. See original summary.

shetpooja04’s picture

shetpooja04 CreditAttribution: shetpooja04 at QED42 commented
Assigned: shetpooja04 » Unassigned
Status: Active » Needs review
FileSize
file_path.png464.31 KB
3173976-2.patch627 bytes

Commit ID: c848fb6b

Link: https://git.drupalcode.org/project/drupal/-/commit/c848fb6b0f7bd09c5633a546a73073a8941cbadf

File: core/modules/system/tests/src/Functional/File/ConfigTest.php Line: 30

For Issue: https://www.drupal.org/project/drupal/issues/3039026 the variable is removed

Please review

lipinponmala007’s picture

lipinponmala007 CreditAttribution: lipinponmala007 at Zyxware Technologies commented

https://www.drupal.org/files/issues/2020-09-30/3173976-2.patch, #2 is working. patch successfully added in 9.1.x-dev branch

lipinponmala007’s picture

lipinponmala007 CreditAttribution: lipinponmala007 at Zyxware Technologies commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 1e5b9c7698 to 9.1.x and c6c224a652 to 9.0.x and 6fdd091c2d to 8.9.x. Thanks!

Backported to 8.9.x to keep tests aligned.

  • alexpott committed 1e5b9c7 on 9.1.x 
    Issue #3173976 by shetpooja04: Remove unused variable $file_path in...

  • alexpott committed c6c224a on 9.0.x 
    Issue #3173976 by shetpooja04: Remove unused variable $file_path in...

  • alexpott committed 6fdd091 on 8.9.x 
    Issue #3173976 by shetpooja04: Remove unused variable $file_path in...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

@shetpooja04 thanks for including information for when the variable became unused. Thats helpful.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.