Problem/Motivation

There is no View link in the local tasks of the contact form. When using modules like clone, devel and entity_usage, it will add new local task links to each contact form. However, those links cannot be easily found unless you know the exact URL for those new links which are not easily known either.

If we have View link in the local tasks of the contact form, we can see all those extra links.

Steps to reproduce

  • Install the contact, and devel modules in a new Drupal website
  • Create a contact form and go to the contact form page
  • the 'Devel' link cannot be found in the contact form page

Proposed resolution

Add a task in the contact module link yml file

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#15 3173756-9.patch1.59 KBpaulocs
#8 3173756-test-only-9.patch1.02 KBpaulocs
#8 3173756-9.patch1.59 KBpaulocs
#6 Screenshot from 2020-09-29 15-11-05.png43.82 KBpaulocs
#5 interdiff_2_5.txt598 bytesanmolgoyal74
#5 3173756-5-contact-form-local-task-view-link.patch591 bytesanmolgoyal74
#2 3173756-2-contact-form-local-task-view-link.patch490 byteseric.chenchao
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

eric.chenchao created an issue. See original summary.

eric.chenchao’s picture

eric.chenchao CreditAttribution: eric.chenchao commented
FileSize
3173756-2-contact-form-local-task-view-link.patch490 bytes
eric.chenchao’s picture

eric.chenchao CreditAttribution: eric.chenchao commented
Status: Active » Needs review
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Version: 9.0.x-dev » 9.1.x-dev
anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
FileSize
3173756-5-contact-form-local-task-view-link.patch591 bytes
interdiff_2_5.txt598 bytes
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screenshot from 2020-09-29 15-11-05.png43.82 KB

Patch #5 looks good. The "View" tab is properly created.
RTBC. I attached screen shot to prove it.

Do we need test coverage for this type of issue? I'm not sure.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Reviewed & tested by the community » Needs review

That is documented.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Issue tags: +Usability
FileSize
3173756-9.patch1.59 KB
3173756-test-only-9.patch1.02 KB

Okay, so I created test for it.
I attached the test only patch and the complete patch.

Cheers, Paulo.

Status: Needs review » Needs work

The last submitted patch, 8: 3173756-test-only-9.patch, failed testing. View results

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Status: Needs work » Needs review

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

eric.chenchao’s picture

eric.chenchao CreditAttribution: eric.chenchao commented

Looks good to me

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Status: Needs review » Reviewed & tested by the community

Moving to RTBC per comment #12.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Reviewed & tested by the community » Needs work

This is retesting the fail patch instead of the patch for commit. Can someone re-upload the 'success' patch so that is the one tested? Setting to NW for that, sorry.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Status: Needs work » Reviewed & tested by the community
FileSize
3173756-9.patch1.59 KB

Re-uploading patch #9 and moving back to RTBC!

NitinLama’s picture

NitinLama CreditAttribution: NitinLama as a volunteer and at OpenSense Labs commented

Patch #15 looks good.

  • catch committed d02178b on 9.2.x 
    Issue #3173756 by paulocs, anmolgoyal74, eric.chenchao: Add local task...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed d02178b and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.