Problem/Motivation

Repeated 'not' word in PharExtensionInterceptor.php

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anmolgoyal74 created an issue. See original summary.

asishsajeev’s picture

Assigned: Unassigned » asishsajeev
asishsajeev’s picture

Status: Needs review » Reviewed & tested by the community

Patch looks fine.

asishsajeev’s picture

Assigned: asishsajeev » Unassigned
longwave’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/lib/Drupal/Core/Security/PharExtensionInterceptor.php
@@ -60,7 +60,7 @@ private function baseFileContainsPharExtension($path) {
     // If the stream wrapper is registered by invoking a phar file that does
-    // not not have .phar extension then this should be allowed. For
+    // not have .phar extension then this should be allowed. For
     // example, some CLI tools recommend removing the extension.

This now needs re-wrapping at 80 characters.

longwave’s picture

Title: Repeative 'not' word in PharExtensionInterceptor.php » Repeated 'not' word in PharExtensionInterceptor.php
Issue summary: View changes
anmolgoyal74’s picture

Status: Needs work » Needs review
FileSize
962 bytes
Abhijith S’s picture

Applied patch #7 .It works perfeclty

Checking patch core/lib/Drupal/Core/Security/PharExtensionInterceptor.php...
Applied patch core/lib/Drupal/Core/Security/PharExtensionInterceptor.php cleanly
Abhijith S’s picture

Status: Needs review » Reviewed & tested by the community

  • larowlan committed f90141d on 9.1.x
    Issue #3173435 by anmolgoyal74: Repeated 'not' word in...

  • larowlan committed bae143d on 9.0.x
    Issue #3173435 by anmolgoyal74: Repeated 'not' word in...

  • larowlan committed a4068e5 on 8.9.x
    Issue #3173435 by anmolgoyal74: Repeated 'not' word in...
larowlan’s picture

Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: +Bug Smash Initiative

Committed f90141d and pushed to 9.1.x. Thanks!

Backported to 9.0.x and 8.9.x for branch parity as the risk of regression here is minimal

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.