Problem/Motivation

Saving time on checking standards and practice before committing any code.

#3112172: Drupal 9 compatibility for [Varbase Carousels] with Drupal coding standard and practice


Drupal coding standard and Drupal Practice check should pass

PHPCS, PHPCBF for both --standard=Drupal and --standard=DrupalPractice

Check Varbase Carousels Drupal coding standard

phpcbf --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_carousels/ 

phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_carousels/ 

Check Varbase Carousels Drupal Practice

phpcbf --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_carousels/ 

phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_carousels/

Proposed resolution

yarn phpcs
yarn phpcbf

as

  "scripts": {
    "phpcs": "phpcs --standard=./.phpcs.xml .",
    "phpcbf": "phpcbf --standard=./.phpcs.xml ."
  },

Comments

RajabNatshah created an issue. See original summary.

  • RajabNatshah committed c05b768 on 8.x-7.x
    Issue #3173236: Add yarn script commands for Drupal coding standard and...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Status: Active » Needs review

The inline commands

rajab@vardot-dev:/var/www/html/products/varbase_carousels$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_carousels/ 
rajab@vardot-dev:/var/www/html/products/varbase_carousels$ phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_carousels/

yarn phpcs

rajab@vardot-dev:/var/www/html/products/varbase_carousels$ yarn phpcs
yarn run v1.22.5
$ phpcs --standard=./.phpcs.xml .
Done in 0.84s.

yarn phpcbf

rajab@vardot-dev:/var/www/html/products/varbase_carousels$ yarn phpcbf
yarn run v1.22.5
$ phpcbf --standard=./.phpcs.xml .

No fixable errors were found

Time: 73ms; Memory: 8MB

Done in 0.15s.
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Issue tags: +varbase-8.8.7, +varbase-9.0.0
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue tags: +varbase-9.0.0-alpha1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.