Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
The Simple XML Sitemap setting form lists the status for all XML sitemap variants. This information is useful to display on the Status report, since it can indicate a problem with sitemap generation that requires action by a site administrator.
Proposed resolution
Display the status for XML sitemaps on the Status report page.
Remaining tasks
- Write a patch
- Review
- Submit
User interface changes
The status for XML sitemaps is displayed on the Status report page.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#11 | Screen Shot 2021-05-30 at 2.08.50 am.png | 48.09 KB | dpi |
#11 | Screen Shot 2021-05-30 at 2.09.34 am.png | 62.1 KB | dpi |
#4 | 3172662-4.png | 15.79 KB | kleiton_rodrigues |
#2 | 3172662-2.patch | 6.34 KB | idebr |
#2 | simple_sitemap-status-error.png | 77.29 KB | idebr |
Issue fork simple_sitemap-3172662
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
idebr CreditAttribution: idebr at iO commentedAttached patch displays the status for XML sitemaps on the Status report page.
Status report checked:
Status report error:
Comment #3
anneke_vde CreditAttribution: anneke_vde at iO commentedI tested the patch, the status report page now displays te status of the configured XML sitemaps.
Comment #4
kleiton_rodrigues CreditAttribution: kleiton_rodrigues at CI&T commentedPatch successfully applied and Displayed the status for XML sitemaps on the Status report page.
RTBC + 1
Comment #5
DamienMcKennaI was just saying to a coworker "it'd be really great if Simple Sitemap had a report on the status page..", this would be a good start.
Comment #6
gbyte CreditAttribution: gbyte as a volunteer and at gbyte commentedThanks for the patch. A couple of things:
Comment #7
gbyte CreditAttribution: gbyte as a volunteer and at gbyte commentedComment #10
dpiWorking on something generalised to support this issue and #3215975: Add a Simple Sitemap plugin for Monitoring
Comment #11
dpiNot sure if I'll have time to pick this up again, but this works, and passes tests.
SimplesitemapSitemapsForm
, utilizing new service/domain objectScreens
1.
2.
Other notes
\Drupal\simple_sitemap\Controller\SimplesitemapController::getSitemap
use the new service, and for\Drupal\simple_sitemap\Simplesitemap::getSitemap
and\Drupal\simple_sitemap\Simplesitemap::fetchSitemapVariantInfo
to be deprecated in the future.Comment #12
dpiComment #13
dpiPeople following this issue may also be interested in integration with Monitoring at #3215975: Add a Simple Sitemap plugin for Monitoring , which uses the common parts introduced with the MR above.
Comment #14
gbyte CreditAttribution: gbyte as a volunteer and at gbyte commentedCan we make it work with 4.x? :)
Comment #15
dpi@gbyte can you provide a review? I don’t think it’s reasonable to ask for a major version rebase yet, considering there could be fundamental changes required or a wholesale rejection. Especially when the work has been Needs review for over a year.
Please feel free to provide notes and pointers for reworks in 4.x