The canonical link is missing from AMP pages but only on the testbot, not when testing locally. Other tests should probably be added/updated. So this issue will be doing some work on tests.

CommentFileSizeAuthor
#17 3171624-17-fix-tests.patch53.16 KBKarenS
#15 3171624-15-fix-tests.patch47.33 KBKarenS
#14 3171624-14-fix-tests.patch47.38 KBKarenS
#13 3171624-13-fix-tests.patch37.3 KBKarenS
#10 3171624-10-fix-tests.patch35.88 KBKarenS
#9 3171624-9-fix-tests.patch31.99 KBKarenS
#8 3171624-8-fix-tests.patch22.77 KBKarenS
#6 3171624-6-fix-tests.patch22.77 KBKarenS
#5 3171624-5-fix-tests.patch22.96 KBKarenS
#4 3171624-4-fix-tests.patch16.3 KBKarenS
#2 3171624-2-fix-tests.patch11.92 KBKarenS
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

KarenS created an issue. See original summary.

KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
Status: Active » Needs review
FileSize
3171624-2-fix-tests.patch11.92 KB

First pass, add test for AMP image formatter.

Status: Needs review » Needs work

The last submitted patch, 2: 3171624-2-fix-tests.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
Status: Needs work » Needs review
FileSize
3171624-4-fix-tests.patch16.3 KB

Added a test for image carousel and reworked tests to be more re-usable. Also hid again the broken canonical link temporarily.

KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
FileSize
3171624-5-fix-tests.patch22.96 KB

Add test for media formatter, and more reworking to make tests re-usable.

KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
FileSize
3171624-6-fix-tests.patch22.77 KB

Code cleanup.

Status: Needs review » Needs work

The last submitted patch, 6: 3171624-6-fix-tests.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
Status: Needs work » Needs review
FileSize
3171624-8-fix-tests.patch22.77 KB
KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
FileSize
3171624-9-fix-tests.patch31.99 KB
KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
FileSize
3171624-10-fix-tests.patch35.88 KB

Status: Needs review » Needs work

The last submitted patch, 10: 3171624-10-fix-tests.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
Status: Needs work » Needs review

I'm back to the missing canonical link on AMP pages and have figured out that tests work with Metatag 1.13 and fail with Metatag 1.14, so something in that last Metatag release is causing the problem.

KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
FileSize
3171624-13-fix-tests.patch37.3 KB

There were some changes to the processing order in Metatag for head links, and Metatag has set itself up to run after all other modules. The combination creates problems when AMP wants to step in. The solution for tests is to empty out Metatag's canonical link since the core canonical link works fine. I think this will now pass.

KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
FileSize
3171624-14-fix-tests.patch47.38 KB
KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
FileSize
3171624-15-fix-tests.patch47.33 KB

Status: Needs review » Needs work

The last submitted patch, 15: 3171624-15-fix-tests.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
Status: Needs work » Needs review
FileSize
3171624-17-fix-tests.patch53.16 KB

  • KarenS committed 360e40f on 8.x-3.x 
    Issue #3171624 by KarenS: Fix and update tests
KarenS’s picture

KarenS CreditAttribution: KarenS at Lullabot commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.