Problem/Motivation

In comment #55 in #2630732: Implement Entity::fields() for migration destinations joachim mentioned that default_bundle was something created for that patch. It isn't, it is a Destination plugin configuration but not documented in Entity.

Steps to reproduce

Proposed resolution

Add the documentation.

Remaining tasks

Patch. review, commit

CommentFileSizeAuthor
#2 3171510-2.patch1.52 KBquietone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
1.52 KB

A simple patch

mikelutz’s picture

Status: Needs review » Reviewed & tested by the community

It is odd to me that this is defined in Entity. I've looked at the relationships between Entity and EntityConfigBase and EntityContentBase before and thought they were wonky, and this just makes me want to mention it again. I realize there are reasons with the derived entity destinations, but with EntityConfigBase and EntityContentBase both inheriting from Entity, it is so strange to me to be dealing with bundles in Entity, and then overriding that behavior in EntityConfigBase to not use them, rather than to put the bundle stuff into EntityContentBase to begin with.

Anyway, that rant has nothing to do with this issue, the documentation here is good to go.

alexpott’s picture

Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed bf5aa399de to 9.1.x and 38f194be1d to 9.0.x and 73345f7556 to 8.9.x. Thanks!

Backported to 8.9.x since this is a docs fix.

  • alexpott committed bf5aa39 on 9.1.x
    Issue #3171510 by quietone: Add documentation for default_bundle to...

  • alexpott committed 38f194b on 9.0.x
    Issue #3171510 by quietone: Add documentation for default_bundle to...

  • alexpott committed 73345f7 on 8.9.x
    Issue #3171510 by quietone: Add documentation for default_bundle to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.