Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Would be difficult to allow specifying multiple customers linked to one pricelist?
Or it would be a bad idea?
Should I try to reproduce the work done here?
https://www.drupal.org/project/commerce_pricelist/issues/3020851
This module is really powerful, thanks a lot for your good work.
Comment | File | Size | Author |
---|---|---|---|
#8 | interdiff_7-8.txt | 1.85 KB | jsacksick |
#8 | 3171289-8.patch | 17.71 KB | jsacksick |
|
Comments
Comment #2
jsacksick CreditAttribution: jsacksick at Centarro commentedI think it's a great idea, I've always wondered why this field didn't allow multiple values.
The only problem is that I think we need to keep the existing methods for getting/setting the customer
getCustomer()
,getCustomerId()
,setCustomer()
andsetCustomerId()
for backward compatibility.The
getCustomerRole()
method was simply removed in #3020851: Support specifying multiple customer roles but I don't think we can do that this time (since that could break code expecting the methods to be there and we're now close to a full release).Comment #4
jsacksick CreditAttribution: jsacksick at Centarro commentedForgot to update functional tests...
Comment #5
jsacksick CreditAttribution: jsacksick at Centarro commentedGood thing we have tests coverage for this :), the attached patch should be the one, hopefully :).
Comment #7
jsacksick CreditAttribution: jsacksick at Centarro commentedComment #8
jsacksick CreditAttribution: jsacksick at Centarro commentedAttempt to fix the coding standard warnings due to the wrong format of the deprecation warnings.
Comment #10
jsacksick CreditAttribution: jsacksick at Centarro commentedCommitted!
Comment #11
zenimagine CreditAttribution: zenimagine commentedComment #12
jsacksick CreditAttribution: jsacksick at Centarro commented