Would be difficult to allow specifying multiple customers linked to one pricelist?
Or it would be a bad idea?

Should I try to reproduce the work done here?
https://www.drupal.org/project/commerce_pricelist/issues/3020851

This module is really powerful, thanks a lot for your good work.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Luca Cattaneo created an issue. See original summary.

jsacksick’s picture

Status: Active » Needs review
FileSize
12.41 KB

I think it's a great idea, I've always wondered why this field didn't allow multiple values.

The only problem is that I think we need to keep the existing methods for getting/setting the customer getCustomer(), getCustomerId(), setCustomer() and setCustomerId() for backward compatibility.

The getCustomerRole() method was simply removed in #3020851: Support specifying multiple customer roles but I don't think we can do that this time (since that could break code expecting the methods to be there and we're now close to a full release).

Status: Needs review » Needs work

The last submitted patch, 2: 3171289-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jsacksick’s picture

Status: Needs work » Needs review
FileSize
14.95 KB
2.45 KB

Forgot to update functional tests...

jsacksick’s picture

FileSize
15.14 KB
872 bytes

Good thing we have tests coverage for this :), the attached patch should be the one, hopefully :).

Status: Needs review » Needs work

The last submitted patch, 5: 3171289-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jsacksick’s picture

Status: Needs work » Needs review
FileSize
17.62 KB
4.69 KB
jsacksick’s picture

FileSize
17.71 KB
1.85 KB

Attempt to fix the coding standard warnings due to the wrong format of the deprecation warnings.

  • jsacksick committed b303f82 on 8.x-2.x
    Issue #3171289 by jsacksick: Support specifying multiple customers.
    
jsacksick’s picture

Status: Needs review » Fixed

Committed!

zenimagine’s picture

Status: Fixed » Needs work
Related issues: +#3180362: Table information not available for the 'customers' field
jsacksick’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.