Problem/Motivation

In core/modules/migrate/tests/src/Unit/MigrateExecutableTest.php, $iterator variables are never used.

CommentFileSizeAuthor
#2 unused_variable.png273.16 KBshetpooja04
#2 3170972-2.patch670 bytesshetpooja04
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shetpooja04 created an issue. See original summary.

shetpooja04’s picture

shetpooja04 CreditAttribution: shetpooja04 at QED42 commented
Assigned: shetpooja04 » Unassigned
Status: Active » Needs review
FileSize
3170972-2.patch670 bytes
unused_variable.png273.16 KB

Commit ID: 643dc7a4

Link: https://git.drupalcode.org/project/drupal/-/commit/643dc7a452860c1be3f9c06af15b75980f2ef680

For Issue: https://www.drupal.org/project/drupal/issues/2452217 the variables were added

File: core/modules/migrate/tests/src/Unit/MigrateExecutableTest.php

$iterator variable were removed

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

@shetpooja04, thanks for that patch. Having the link to the issue where the use of the variable was removed was really helpful. That made this easy to review.

I looked at the issued referred and confirmed that the one use of the local variable was removed. I installed that patch and checked that $iterator was not used.

Yes, this is good to go.

  • catch committed a5cb5e4 on 9.1.x 
    Issue #3170972 by shetpooja04, quietone: Remove unused variable $...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed a5cb5e4 and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.