Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.| Comment | File | Size | Author |
|---|---|---|---|
| #4 | before-patch.png | 154.75 KB | amietpatial |
| #4 | after_patch.png | 150.84 KB | amietpatial |
| #3 | Screen Shot 2020-09-14 at 4.23.57 AM.png | 329.17 KB | tanubansal |
| #2 | 3170675-2.patch | 1010 bytes | Neslee Canil Pinto |
Comments
Comment #2
Neslee Canil PintoComment #3
tanubansal CreditAttribution: tanubansal at Salsa Digital commentedTested #2, changes are visible.
This can be moved to RTBC
Comment #4
amietpatial CreditAttribution: amietpatial as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented#2 is executed fine, so moving to RTBC after and before screenshot attached.
Comment #6
catch@amietpatial and @tanubansal it's not necessary to post screenshots of the code with the patch applied, since the difference can be seen from the patch itself. More appropriate testing here would have been to manually copy and paste the new link and make sure it goes to the correct place (in this case it's the same as the old one, but without a 301 redirect).
Committed 8d9123a and pushed to 9.1.x. Thanks!
Comment #7
amietpatial CreditAttribution: amietpatial as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented@catch thank you for the feedback will pay heed to this in future :)