Problem/Motivation

As @larowlan comment on issue #3162603: EntityStorageBase::loadByProperties() is broken on PostgreSQL when using two or more case insensitive properties (comment #31), NodeLoadMultipleTest should be a kernel test.

Proposed resolution

Split NodeLoadMultipleTest into two things, the loading functionality should be a kernel test and the frontpage view test can be an existing test.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

paulocs created an issue. See original summary.

paulocs’s picture

Status: Active » Needs review
FileSize
3.96 KB

A patch for it.

longwave’s picture

\Drupal\Tests\node\Functional\Views\FrontPageTest already exists and is more comprehensive.

\Drupal\Tests\system\Functional\System\FrontPageTest also has some overlapping functionality.

Can we just drop NodePromotedTest?

paulocs’s picture

For me makes sense @longwave. I think there is no need to have FrontPageTest

I attached a new patch for it.

longwave’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, looks good to me.

  • alexpott committed 4566403 on 9.1.x
    Issue #3170246 by paulocs, longwave: NodeLoadMultipleTest.php should be...

  • alexpott committed b58a924 on 9.0.x
    Issue #3170246 by paulocs, longwave: NodeLoadMultipleTest.php should be...
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 4566403054 to 9.1.x and b58a924af7 to 9.0.x. Thanks!

Backported to 9.0.x as this is a test change.

alexpott’s picture

Version: 9.1.x-dev » 9.0.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.