Fix Varbase update helper hook implementations do not check the checklist id issue [#3168971]

Comment	File	Size	Author
#2	varbase_update_helper_check_id-3168971-2.patch	5.72 KB	mhawwari

Comment #1

3 September 2020 at 16:03

mhawwari created an issue. See original summary.

Log in or register to post comments

Comment #2

mhawwari CreditAttribution: mhawwari at Vardot commented 3 September 2020 at 16:09

Assigned:	mhawwari	» Unassigned
Status:	Active	» Needs review

File	Size
varbase_update_helper_check_id-3168971-2.patch	5.72 KB

I added ID checks for all form hooks implemented in varbase_update_helper.module

Log in or register to post comments

Comment #3

3 September 2020 at 16:14

Status:

Needs review

» Needs work

The last submitted patch, 2: varbase_update_helper_check_id-3168971-2.patch, failed testing. View results

Log in or register to post comments

Comment #4

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 3 September 2020 at 16:23

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #5

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 5 September 2020 at 06:11

Title:

Varbase update helper hook implementations don't check the checklist id

» Fix Varbase update helper hook implementations don't check the checklist id issue

Log in or register to post comments

Comment #6

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 5 September 2020 at 06:12

Title:

Fix Varbase update helper hook implementations don't check the checklist id issue

» Fix Varbase update helper hook implementations do not check the checklist id issue

Log in or register to post comments

Comment #7

5 September 2020 at 06:17

RajabNatshah committed d6c8725 on 9.0.x authored by mhawwari

Issue #3168971 by mhawwari: Fix Varbase update helper hook...

Log in or register to post comments

Comment #8

5 September 2020 at 06:20

RajabNatshah committed 9f53334 on 8.x-8.x authored by mhawwari

Issue #3168971 by mhawwari: Fix Varbase update helper hook...

Log in or register to post comments

Comment #9

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented 5 September 2020 at 06:22

Assigned:	Unassigned	» Mohammed J. Razem
Issue tags:		+varbase-8.8.7, +varbase-9.0.0

Committed ... Thank you Hawwari <3

rajab@vardot-dev:/var/www/html/products/varbase_core$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_core/ --ignore="modules/varbase_tour/node_modules"

rajab@vardot-dev:/var/www/html/products/varbase_core$ phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_core/ --ignore="modules/varbase_tour/node_modules"