Problem/Motivation

Symfony 4.4.13 has been released.

Also please see CVE-2020-15094: Prevent RCE when calling untrusted remote with CachingHttpClient

Proposed resolution

Upgrade Symfony components on 9.0.x branch from 4.4.7 to 4.4.13.
Upgrade Symfony components on 9.1.x branch from 4.4.12 to 4.4.13.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

suzymasri created an issue. See original summary.

suzymasri’s picture

Issue summary: View changes
xjm’s picture

Priority: Normal » Major

Note that core is not vulnerable to this issue, so we've agreed this update can be handled in public. The main annoyance is automated security testing failing because of the attached http-kernel update.

Dane Powell’s picture

I think this should be considered major or critical and requires an immediate core release to upgrade symfony/http-kernel.

My understanding is that best practice is for end users to require drupal/core-recommended instead of drupal/core. This pins symfony/http-kernel to a vulnerable version with no way for end users to override it. *

This means that out of the box, all new Drupal sites build on drupal/recommended-project (which also depends on drupal/core-recommended) will also be affected with no possibility of making them secure without a new release.

This is partially mitigated if the vulnerability doesn't actually affect Drupal, but this will still wreak havoc given how many users probably make use of automated security scans and Composer security advisories.

* technically you might be able to use Composer version aliases in your composer.json or fork drupal/core-recommended or something to override it, but let's not go there

xjm’s picture

xjm’s picture

9.1.x also needs its own patch apparently.

longwave’s picture

Status: Needs review » Reviewed & tested by the community

I checked each of the patches and the 9.1/9.0/8.9 patches contain the minimum set of changes required to upgrade the package in question.

The 8.8 patch contains additional funding information as it was created with Composer 1.10 and the previous lock file must have been created with Composer 1.9, but this won't affect anything and it is probably better to be consistent.

Therefore this is RTBC assuming the tests pass.

xjm’s picture

Version: 9.0.x-dev » 8.8.x-dev

  • catch committed 6ca8fda on 9.1.x
    Issue #3168763 by xjm, suzymasri, longwave: Update Symfony to 4.4.13 to...

  • catch committed b0599cf on 9.0.x
    Issue #3168763 by xjm, suzymasri, longwave: Update Symfony to 4.4.13 to...

  • catch committed ad1b6e1 on 8.9.x
    Issue #3168763 by xjm, suzymasri, longwave: Update Symfony to 4.4.13 to...

  • catch committed 64315df on 8.8.x
    Issue #3168763 by xjm, suzymasri, longwave: Update Symfony to 4.4.13 to...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed the respective patches to all four branches.

timmillwood’s picture

I think it'd be nice to add Roave/SecurityAdvisories library to Drupal core, so created #3168853: Add Roave/SecurityAdvisories to Drupal core to discuss.

longwave’s picture

Just realised that this only updates symfony/http-kernel and not all of Symfony as per the title, but I suppose this is a technicality, we don't need point releases to be in sync as far as I know (unless a bug fix relies on another bug fix in a related component, I suppose).

xjm’s picture

Title: Update Symfony to 4.4.13 to address CVE-2020-15094 » Update Symfony http-kernel to 4.4.13 to address CVE-2020-15094
Issue tags: +Needs followup

@longwave, we generally limit the updates we do in patch releases to the affected component(s). We can have a further update of Symfony in 9.1.

Tagging "Needs followup" for that, since #3157296: Upgrade dependencies prior to 9.1.0 just updated Symfony components to 4.4.12.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.