Problem/Motivation

In core/modules/locale/locale.module, $frequency variable never used.

CommentFileSizeAuthor
#2 frequency_unused.png457.69 KBshetpooja04
#2 3167599-2.patch797 bytesshetpooja04
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shetpooja04 created an issue. See original summary.

shetpooja04’s picture

shetpooja04 CreditAttribution: shetpooja04 at QED42 commented
Assigned: shetpooja04 » Unassigned
Status: Active » Needs review
FileSize
3167599-2.patch797 bytes
frequency_unused.png457.69 KB

Commit ID: c1f21810

Link: https://git.drupalcode.org/project/drupal/-/commit/c1f21810359878431af59e3156f81bec8a84de4f

For Issue: https://www.drupal.org/project/drupal/issues/1998056 the changes were made

File: core/modules/locale/locale.module

$frequency is never getting used.

jijojoseph_zyxware’s picture

jijojoseph_zyxware CreditAttribution: jijojoseph_zyxware as a volunteer and at Zyxware Technologies commented
Status: Needs review » Reviewed & tested by the community

Thanks for researching this, I agree with your findings that we don't need this variable $frequency.

Patch applied cleanly.

RTBC!!!

  • catch committed c7558c4 on 9.1.x 
    Issue #3167599 by shetpooja04, jijojoseph_zyxware: Unused variable $...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Double checked that the interval is used later, and it's in https://api.drupal.org/api/drupal/core%21modules%21locale%21locale.trans...

Committed c7558c4 and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.