Here is the code block.

 * Example usage:
 * @code
 * $form['email'] = array(
 *   '#type' => 'email',
 *   '#title' => $this->t('Email'),
 *   '#pattern' => '*@example.com',
 * );
 * @end
 *
 * @see \Drupal\Core\Render\Element\Render\Textfield

I propose the following.

  1. Covert to short array syntax
  2. Replace@end with @endcode
  3. Fix broken @see reference

Note that @end tag triggers autoloader which is kind of performance issue. See #2557433: Add internal, event, and property to the list of ignored annotations in the plugin annotation system for details.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi created an issue. See original summary.

sarvjeetsingh’s picture

Assigned: Unassigned » sarvjeetsingh
davidhernandez’s picture

Assigned: sarvjeetsingh » Unassigned
Status: Active » Needs review
FileSize
623 bytes
sarvjeetsingh’s picture

Status: Needs review » Needs work

I think @see still needs to be fixed. In the patch #3 , @see is pointing to itself which needs to be fixed.

sarvjeetsingh’s picture

Assigned: Unassigned » sarvjeetsingh
sarvjeetsingh’s picture

Assigned: sarvjeetsingh » Unassigned
Status: Needs work » Needs review
FileSize
627 bytes
375 bytes

I have fixed the @see and updated the previous patch.
please review
Thanks!

Chi’s picture

Status: Needs review » Reviewed & tested by the community

Thank you.

  • lauriii committed fe434ee on 9.1.x
    Issue #3167196 by sarvjeetsingh, davidhernandez, Chi: Fix...

  • lauriii committed f7099b7 on 9.0.x
    Issue #3167196 by sarvjeetsingh, davidhernandez, Chi: Fix...

  • lauriii committed 55573d7 on 8.9.x
    Issue #3167196 by sarvjeetsingh, davidhernandez, Chi: Fix...
lauriii’s picture

Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

As a doc fix, committed fe434ee and pushed to 9.1.x, 9.0.x and 8.9.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.