Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
This issue is a child issue from #3145418: [November 9, 2020] Remove uses of t() in assertText() calls because if fix uses of t() in assertNoText() the patch would be to big and difficult to review.
Proposed resolution
Fix uses of t() in assertNoText(). Tests should not have t() calls inside assertNoText(). Only if it is testing translation.
Comment | File | Size | Author |
---|---|---|---|
#12 | interdiff_9-12.txt | 2.43 KB | snehalgaikwad |
#12 | 3166349-12.patch | 76.02 KB | snehalgaikwad |
#9 | 3166349-3.patch | 76.17 KB | naresh_bavaskar |
Comments
Comment #2
paulocsI will work on it.
Comment #3
paulocsPatch to remove all t() calls inside assertNoText().
Please review it.
Cheers, Paulo
Comment #5
paulocsFixing errors.
Comment #7
naresh_bavaskarComment #8
naresh_bavaskar#5 patch looks good to me..might random test cases were failed. trying to re-upload it.
Comment #9
naresh_bavaskarComment #11
mondrakeThe string should be enclosed in double quotes (") in order for $label to be replaced with the variable's value.
same
same
Comment #12
snehalgaikwad CreditAttribution: snehalgaikwad as a volunteer and at QED42 for Drupal India Association commentedChanged string quotes to double as per #11.
Comment #13
mondrakeThank you.
Comment #14
mondrakeComment #16
catchCommitted f4fd2d7 and pushed to 9.1.x. Thanks!