Problem/Motivation

In core/modules/jsonapi/tests/src/Functional/ResourceTestBase.php, $account_bundle variable never used.

CommentFileSizeAuthor
#2 3165794-2.patch580 bytesshetpooja04
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shetpooja04 created an issue. See original summary.

shetpooja04’s picture

shetpooja04 CreditAttribution: shetpooja04 at QED42 commented
Assigned: shetpooja04 » Unassigned
Status: Active » Needs review
FileSize
3165794-2.patch580 bytes

Commit ID: e59ec93f

Link: https://git.drupalcode.org/project/drupal/-/commit/e59ec93f502e8e63e3b2e2006ff47f21ced19228

For Issue: https://www.drupal.org/project/drupal/issues/2843147 the changes were made in this issue

File: core/modules/jsonapi/tests/src/Functional/ResourceTestBase.php

$account_bundle is never getting used

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

$account is only used in the test method to set up an entity reference, the bundle isn't needed, therefore this variable is redundant and can be removed.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed d2e7c1f and pushed to 9.1.x. Thanks!

  • catch committed d2e7c1f on 9.1.x 
    Issue #3165794 by shetpooja04, longwave: Unused variable $account_bundle...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.