Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
In core/modules/field/tests/src/Kernel/FieldAttachStorageTest.php, $field_ids variable never used.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3165191-5.patch | 635 bytes | shetpooja04 |
Comments
Comment #2
shetpooja04 CreditAttribution: shetpooja04 at QED42 commentedCommit ID: a57630c8
Link: https://git.drupalcode.org/project/drupal/-/commit/a57630c83d508a0916f0429534b253a232e9c0fb
For Issue: https://www.drupal.org/project/drupal/issues/2287727 #32 the changes were made
File: core/modules/field/src/Tests/FieldAttachStorageTest.php
$field_ids is never getting used in testGetSourceContextException()
Comment #3
longwaveNo patch attached.
Comment #4
shetpooja04 CreditAttribution: shetpooja04 at QED42 for Drupal India Association commentedworking on this
Comment #5
shetpooja04 CreditAttribution: shetpooja04 at QED42 for Drupal India Association commentedUploaded the patch, Please review
Comment #6
chaithanya.m CreditAttribution: chaithanya.m commented$field_ids is never used anywhere within FieldAttachStorageTest.php. Applied patch 3165191-5.patch and works fine.
Comment #7
catchhttps://git.drupalcode.org/project/drupal/-/commit/a57630c83d508a0916f04... is the commit where this line was last changed, but it's not the commit where it was added, so to be sure, we should git log -S the older code that was changed, and see where that was added.
Comment #8
longwave$field_idswas needed until a refactoring in #1969728: Implement Field API "field types" as TypedData Plugins committed as a2c2367 removed use of the variable, but the initialisation wasn't removed.Comment #10
catchCommitted f0d27d2 and pushed to 9.1.x. Thanks!