Problem/Motivation

In core/modules/help_topics/tests/src/Unit/HelpTopicTwigLoaderTest.php, $source variable never used.

CommentFileSizeAuthor
#4 interdiff-2-4.txt634 bytesHardik_Patel_12
#4 3164965-4.patch851 bytesHardik_Patel_12
#2 unused-variable-source.png500.95 KBshetpooja04
#2 3164965-2.patch733 bytesshetpooja04
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shetpooja04 created an issue. See original summary.

shetpooja04’s picture

shetpooja04 CreditAttribution: shetpooja04 at QED42 commented
Assigned: shetpooja04 » Unassigned
Status: Active » Needs review
FileSize
3164965-2.patch733 bytes
unused-variable-source.png500.95 KB

Commit ID: 5691efb0 Link: https://git.drupalcode.org/project/drupal/-/commit/5691efb09bde15442d3754b5c54fdac7a593ca3d

For Issue: https://www.drupal.org/project/drupal/issues/3069109 #7 the changes were made

File: core/modules/help_topics/tests/src/Unit/HelpTopicTwigLoaderTest.php

$source is never getting used in testGetSourceContextException()

Status: Needs review » Needs work

The last submitted patch, 2: 3164965-2.patch, failed testing. View results

Hardik_Patel_12’s picture

Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3164965-4.patch851 bytes
interdiff-2-4.txt634 bytes

We can remove just $source variable instead of removing getSourceContext function, kindly review.

jijojoseph_zyxware’s picture

jijojoseph_zyxware CreditAttribution: jijojoseph_zyxware as a volunteer and at Zyxware Technologies commented
Status: Needs review » Reviewed & tested by the community

I have reviewed the Patch #4. $source is never getting used. It is working fine without this variable.

@Hardik_Patel_12 Thanks for your patch.

RTBC!!!!!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 3164965-4.patch, failed testing. View results

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Reviewed & tested by the community

Changing to RTBC!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 9e546b3 and pushed to 9.1.x. Thanks!

  • catch committed 9e546b3 on 9.1.x 
    Issue #3164965 by shetpooja04, Hardik_Patel_12: Unused variable $source...
jijojoseph_zyxware’s picture

jijojoseph_zyxware CreditAttribution: jijojoseph_zyxware as a volunteer and at Zyxware Technologies commented

Thanks!!! @catch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.