Problem/Motivation

Some words on the dictionary and the core's code doesn't exists or are misspelled.

Proposed resolution

Fix or ignore the following list of words on the code and remove them from the dictionary:

  • anotherwordenglish > fix
  • anotherwordgerman > fix
  • asdrsad > ignore
  • barmm > ignore
  • foomm > ignore
  • hilfetestmodul > ignore
  • nonwordgerman > fix
  • nonworditem > fix
  • notawordenglish > fix
  • notawordgerman > fix
  • sdeeeee > ignore
  • sqruct > ignore
  • wcsrefsdf > ignore
  • übersetzung > ignore

Remaining tasks

Do a reroll; update the IS. Review

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle’s picture

Status: Active » Needs review
FileSize
6.71 KB

The first iteration.

jungle’s picture

Title: Fix or ignore words used in Help Topics » Fix or ignore 15 words used in Help Topics
jungle’s picture

FileSize
1.82 KB
6.76 KB
+++ b/core/modules/help_topics/tests/modules/help_topics_test/src/Plugin/HelpSection/TestHelpSection.php
@@ -8,8 +8,8 @@
-// cspell:ignore anotherwordenglish anotherwordgerman asdrsad barmm foomm notawordenglish notawordgerman sdeeeee sqruct

+++ b/core/modules/help_topics/tests/src/Functional/HelpTopicSearchTest.php
@@ -5,8 +5,10 @@
-// cspell:ignore anotherwordenglish anotherwordgerman asdrsad barmm foomm hilfetestmodul nonwordgerman nonworditem notawordenglish notawordgerman sdeeeee sqruct

Over 80 chars. Addressing.

quietone’s picture

Status: Needs review » Needs work
Issue tags: +Novice, +Needs reroll
kishor_kolekar’s picture

Status: Needs work » Needs review
FileSize
6.6 KB
3 KB

re-roll the patch.

KapilV’s picture

Issue tags: -Needs reroll

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Abhijith S’s picture

Rerolled patch .Please check this

jungle’s picture

+++ b/core/modules/help_topics/tests/modules/help_topics_test/src/Plugin/HelpSection/TestHelpSection.php
@@ -8,6 +8,9 @@
+// cspell:ignore anotherwordenglish anotherwordgerman asdrsad barmm foomm
+// cspell:ignore notawordenglish notawordgerman sdeeeee sqruct wcsrefsdf

+++ b/core/modules/help_topics/tests/src/Functional/HelpTopicSearchTest.php
@@ -5,6 +5,11 @@
+// cspell:ignore notawordgerman sdeeeee sqruct cspell:ignore übersetzung
+// cspell:ignore wcsrefsdf

+++ b/core/modules/help_topics/tests/src/Functional/HelpTopicTranslationTest.php
@@ -2,6 +2,8 @@
+// cspell:ignore hilfetestmodul übersetzung

Rerolled and made some changes.

jungle’s picture

FileSize
6.35 KB
1.39 KB

Removing übersetzung further.

After:

$ yarn spellcheck:core
yarn run v1.22.4
$ cspell "**/*" ".*" "../composer/**/*" "../composer.json"
CSpell: Files checked: 15135, Issues found: 0 in 0 files
✨  Done in 236.68s.
quietone’s picture

Status: Needs review » Needs work
Issue tags: -Novice
+++ b/core/modules/help_topics/tests/src/Functional/HelpTopicSearchTest.php
@@ -5,6 +5,9 @@
+// cspell:ignore asdrsad barmm foomm hilfetestmodul nonwordgerman notawordgerman

@@ -130,7 +133,7 @@ public function testHelpSearch() {
+    $this->drupalPostForm('search/help', ['keys' => 'non-word-item'], 'Search');

If nonworditem becomes non-word-item why doesn't nonwordgerman follow the same pattern and bceome non-word-german?

ravi.shankar’s picture

Status: Needs work » Needs review
FileSize
6.92 KB
1.41 KB

Made changes as per comment #13, please review.

sulfikar_s’s picture

Updated some more changes as per our problem requirements. Also attaching the interdiff.

Please review!

quietone’s picture

On a brief look the latest patch look good.

Reading the IS, all of the words identified by jungle are not yet removed from the dictionary and added as needed to the cspell ignore lines. Let's make sure all of them are moved to cspell ignore lines and removed from the dictionary in this patch and check if there are any others.

quietone’s picture

Status: Needs review » Needs work
paulocs’s picture

I'll work on it.

paulocs’s picture

Status: Needs work » Needs review
FileSize
7.32 KB

Added "sdeeeee" to the patch.
I was not able to create an interdiff because patch #15 needed a re-roll.

quietone’s picture

@paulocs, thanks for the patch. When the interdiff fails, make a diff, see Creating an interdiff-#What about rerolled patches?

I must be missing something about these Help topic tests.

wcsrefsdf is used in \Drupal\Tests\help_topics\Functional\HelpTopicSearchTest::testHelpSearch. I don't understand why this is using the string 'wcsrefsdf'. It appears to be an title in English so why not use a correctly spelled English word.
$session->linkExists('Foo in English title wcsrefsdf');

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vikashsoni’s picture

#12 #15 and #19 not applying in durpal-9.3.x-dev
Needs to re-roll

error: patch failed: core/misc/cspell/dictionary.txt:44
error: core/misc/cspell/dictionary.txt: patch does not apply
Checking patch core/modules/help_topics/tests/modules/help_topics_test/help_topics/help_topics_test.test.html.twig...
Checking patch core/modules/help_topics/tests/modules/help_topics_test/src/Plugin/HelpSection/TestHelpSection.php...
Checking patch core/modules/help_topics/tests/src/Functional/HelpTopicSearchTest.php...
error: while searching for:
// All of the above tests used the TestHelpSection plugin. Also verify
// that we can search for translated regular help topics, in both English
// and German.
$this->drupalPostForm('search/help', ['keys' => 'nonworditem'], 'Search');
$this->assertSearchResultsCount(1);
$session->linkExists('ABC Help Test module');
// Click the link and verify we ended up on the topic page.
$this->clickLink('ABC Help Test module');
$session->pageTextContains('This is a test');

$this->drupalPostForm('search/help', ['keys' => 'nonwordgerman'], 'Search', [
'language' => $german,
]);
$this->assertSearchResultsCount(1);

error: patch failed: core/modules/help_topics/tests/src/Functional/HelpTopicSearchTest.php:136
error: core/modules/help_topics/tests/src/Functional/HelpTopicSearchTest.php: patch does not apply
Checking patch core/modules/help_topics/tests/src/Functional/HelpTopicTranslatedTestBase.php...
Checking patch core/modules/help_topics/tests/src/Functional/HelpTopicTranslationTest.php...

quietone’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll, +Needs issue summary update

@vikashsoni, I think you forgot to set this to Needs Work. Thank you for your interest. Posting details of a patch not failing is not necessary and adds noise to the issue. If you haven't already read it the contributor guide on Drupal.org has information about how to contribute, particularly the process to Review a patch or merge request. There are also clear guidelines for How is credit granted for Drupal core issues. Thanks

Setting to NW and adding reroll tag. Also when the patch is updated, the list of words in the IS needs to be updated as well.

When rerolling following the instructions for working with cspell. there is a link to the instructions in the Issue Summary of the parent issue, #3122088: [Meta] Remove spelling errors from dictionary.txt and fix them. Thanks

andregp’s picture

Assigned: jungle » andregp
Issue summary: View changes

Just updating the IS formatting.

I'l work on a reroll.

andregp’s picture

Assigned: andregp » Unassigned
Issue summary: View changes
Status: Needs work » Needs review
FileSize
11.19 KB
12.7 KB

Made the reroll, also changed the words: anotherwordenglish anotherwordgerman nonwordgerman nonworditem notawordenglish notawordgerman to use hiphens just to keep consistency (inspired on comment #13).

Here is the patch and a diff.

andregp’s picture

Issue summary: View changes
Issue tags: -Needs reroll, -Needs issue summary update
jungle’s picture

Status: Needs review » Needs work

Thanks @andregp. Tests did not pass in #26.

ankithashetty’s picture

Status: Needs work » Needs review
FileSize
11.18 KB
2.53 KB

Rerolled the patch in #26, thanks!

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

WagnerMelo’s picture

Hello, i rerolled the patch #29, and its needs review.

longwave’s picture

Status: Needs review » Reviewed & tested by the community

This looks OK to me.

ravi.shankar’s picture

Added a reroll of patch #31 for Drupal 10.0.x.

alexpott’s picture

Version: 9.5.x-dev » 9.4.x-dev
Component: base system » help.module
Status: Reviewed & tested by the community » Fixed

Committed a28c9b3 and pushed to 10.0.x. Thanks!
Committed and pushed 60d6c151a9 to 9.5.x and 1301a82faf to 9.4.x. Thanks!

Backported to 9.4.x as the changes are to tests.

  • alexpott committed a28c9b3 on 10.0.x
    Issue #3164699 by jungle, ravi.shankar, andregp, kishor_kolekar,...

  • alexpott committed 60d6c15 on 9.5.x
    Issue #3164699 by jungle, ravi.shankar, andregp, kishor_kolekar,...

  • alexpott committed 1301a82 on 9.4.x
    Issue #3164699 by jungle, ravi.shankar, andregp, kishor_kolekar,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.