Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
In Claro admin theme, the preview button looks like:
Button classes should be adjusted according to the context.
Steps to reproduce
Just enable the module in a site using Claro as the admin theme.
Proposed resolution
In Paragraphs, button classes are set according to the "item mode" that is determined after a complex logic. Copy classes from existing button could be a way of avoid calculation of the appropriate button classes.
Remaining tasks
Review.
User interface changes
None.
API changes
N/A
Data model changes
N/A
Comment | File | Size | Author |
---|---|---|---|
#3 | 2020-09-23_07-19-18.png | 47.36 KB | Danny Englander |
#2 | paragraphs_previewer-preview_button_style_as_context-3164518-2.patch | 1.7 KB | manuel.adan |
Comments
Comment #2
manuel.adanAfter the patch:
Comment #3
Danny EnglanderI've reviewed this patch and it looks good. I now see a nicely styled preview button when using the Claro admin theme.
Comment #4
Danny EnglanderComment #6
recrit CreditAttribution: recrit at Phase2 commentedlooks good, committed to 8.x-1.x