Problem/Motivation

In core/modules/content_moderation/content_moderation.module, $entity_type_ids variable never used.

CommentFileSizeAuthor
#4 unusedvariable_entity_type_ids.png629.38 KBshetpooja04
#2 3164498-2.patch1018 bytesshetpooja04
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shetpooja04 created an issue. See original summary.

shetpooja04’s picture

shetpooja04 CreditAttribution: shetpooja04 at QED42 commented
Assigned: shetpooja04 » Unassigned
Status: Active » Needs review
FileSize
3164498-2.patch1018 bytes

Please review

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented
Status: Needs review » Needs work

Reading this comment and paraphrasing:

We should ... do the work to work out why it is not used.
...
Without doing the work to show why the variable is unused the patch will not be committed.

shetpooja04’s picture

shetpooja04 CreditAttribution: shetpooja04 at QED42 commented
Status: Needs work » Needs review
FileSize
unusedvariable_entity_type_ids.png629.38 KB

Commit ID: 4362606d Link: https://git.drupalcode.org/project/drupal/-/commit/4362606d7106381c7b7c20a415b6d87378971594

For Issue: https://www.drupal.org/project/drupal/issues/3037136 #12 the changes were made

File: core/modules/content_moderation/content_moderation.module

$entity_type_ids is never getting used

jijojoseph_zyxware’s picture

jijojoseph_zyxware CreditAttribution: jijojoseph_zyxware as a volunteer and at Zyxware Technologies commented
Status: Needs review » Reviewed & tested by the community

I have reviewed the Patch. $entity_type_ids is never getting used. It is working fine without this variable.

  • catch committed 336f6fd on 9.1.x 
    Issue #3164498 by shetpooja04, Sam152, jijojoseph_zyxware: Unused...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

#4 shows the variable was added unused.

Committed/pushed to 9.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.