Problem/Motivation

There are fixed typos but they have not been removed from the dictionary

Steps to reproduce

cd core && yarn && yarn spellcheck:make-drupal-dict

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jungle created an issue. See original summary.

jungle’s picture

Status: Active » Needs review
FileSize
795 bytes
jungle’s picture

jungle’s picture

Issue summary: View changes
jungle’s picture

Actually, it's unnecessary running tests. So aborted.

dww’s picture

Thanks for the issue and patch. Since the bot isn't running tests (good idea), I'll say that it applies cleanly to current 9.1.x. ;)

Basically RTBC, but 1 question (point 3):

  1. +++ b/core/misc/cspell/dictionary.txt
    @@ -325,7 +325,6 @@ conkey
    -contant
    
    @@ -807,11 +806,8 @@ instaclick
    -inteface
    -intefacewithconstants
    ...
    -invalida
    

    Confirming the only instances of these in core are from core/tests/Drupal/Tests/Component/Annotation/Doctrine/*. +1 to remove, since that whole directory is being ignored. core/.cspell.json has:

    {
        "ignorePaths": [
          ...
          "tests/Drupal/Tests/Component/Annotation/Doctrine/**",
          ...
    }
    
  2. +++ b/core/misc/cspell/dictionary.txt
    @@ -886,7 +882,6 @@ langcodes
    -lastsplit
    
    @@ -1960,7 +1954,6 @@ uploadsize
    -upserting
    

    Totally gone.

  3. +++ b/core/misc/cspell/dictionary.txt
    @@ -1644,7 +1639,6 @@ subjectkeyword
    -subpackage
    

    core/lib/Drupal/Component/Diff/* uses @subpackage annotations a lot. Can we actually remove this from the dictionary?

Thanks,
-Derek

jungle’s picture

Title: Remove 7 fixed typos from misc/cspell/dictionary.txt » Remove 6/7 fixed typos from misc/cspell/dictionary.txt
FileSize
688 bytes
795 bytes

Thanks @dww!

Re #6.3 Yes, it's a valid word. But prefer removing it, add it back when the day has come.

Uploading two patches with/without "subpackage" so that committer can pick one of them.

jungle’s picture

Title: Remove 6/7 fixed typos from misc/cspell/dictionary.txt » Remove 8 fixed typos from misc/cspell/dictionary.txt
FileSize
896 bytes

One more from upstream. "exdep"

longwave’s picture

Status: Needs review » Reviewed & tested by the community

I think we are OK to remove subpackage now, otherwise we have to have the same discussion if we regenerate the dictionary again in a future issue.

  • catch committed 77e0a5e on 9.1.x
    Issue #3164211 by jungle, dww, longwave: Remove 8 fixed typos from misc/...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed 77e0a5e and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.