Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
There are fixed typos but they have not been removed from the dictionary
Steps to reproduce
cd core && yarn && yarn spellcheck:make-drupal-dict
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#8 | 3164211-8.patch | 896 bytes | jungle |
Comments
Comment #2
jungleComment #3
jungleComment #4
jungleComment #5
jungleActually, it's unnecessary running tests. So aborted.
Comment #6
dwwThanks for the issue and patch. Since the bot isn't running tests (good idea), I'll say that it applies cleanly to current 9.1.x. ;)
Basically RTBC, but 1 question (point 3):
Confirming the only instances of these in core are from
core/tests/Drupal/Tests/Component/Annotation/Doctrine/*
. +1 to remove, since that whole directory is being ignored.core/.cspell.json
has:Totally gone.
core/lib/Drupal/Component/Diff/*
uses@subpackage
annotations a lot. Can we actually remove this from the dictionary?Thanks,
-Derek
Comment #7
jungleThanks @dww!
Re #6.3 Yes, it's a valid word. But prefer removing it, add it back when the day has come.
Uploading two patches with/without "subpackage" so that committer can pick one of them.
Comment #8
jungleOne more from upstream. "exdep"
Comment #9
longwaveI think we are OK to remove subpackage now, otherwise we have to have the same discussion if we regenerate the dictionary again in a future issue.
Comment #11
catchCommitted 77e0a5e and pushed to 9.1.x. Thanks!