Problem/Motivation

Because of #2838423: Drafts for anonymous users the session cache context was added to a webform for anonymous users. This prevents webforms from being cached.

@see https://git.drupalcode.org/project/webform/-/blob/8.x-5.19/src/WebformSu...

Steps to reproduce

Load any webform as an anonymous user. The page is not cached.

Proposed resolution

Only add session context to webform when anonymous users require it

Remaining tasks

Create a patch
Test the patch
Commit the patch

User interface changes

N/A

API changes

TBD

Data model changes

N/A

CommentFileSizeAuthor
#13 3163628-13.patch7.16 KBjrockowitz
#11 3163628-11.patch620 bytesjrockowitz
#9 3163628-9.patch7 KBjrockowitz
#7 3163628-7.patch6.45 KBjrockowitz
#2 3163628-2.patch4.28 KBjrockowitz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Active » Needs review
FileSize
3163628-2.patch4.28 KB
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Issue summary: View changes
Related issues: +#3029842: Session cache context breaks Dynamic Page Cache on webform pages for anonymous users
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Related issues: +#2907459: Anonymous form submissions create a session cookie which may cause performance and scalability issues.

  • e276eea committed on 3163628-improve-session-context-handling 
    Issue #3163628 by jrockowitz: Only add session context to webform when...

  • d972b39 committed on 3163628-improve-session-context-handling 
    Issue #3163628 by jrockowitz: Only add session context to webform when...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
FileSize
3163628-7.patch6.45 KB

  • 126d6ed committed on 3163628-improve-session-context-handling 
    Issue #3163628 by jrockowitz: Only add session context to webform when...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
FileSize
3163628-9.patch7 KB

  • 21b46c6 committed on 3163628-improve-session-context-handling 
    Issue #3163628 by jrockowitz: Only add session context to webform when...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
FileSize
3163628-11.patch620 bytes

  • jrockowitz authored b7ec552 on 3163628-improve-session-context-handling 
    Issue #3163628 by jrockowitz: Only add session context to webform when...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
FileSize
3163628-13.patch7.16 KB
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs review » Reviewed & tested by the community

  • jrockowitz authored 47be422 on 6.x 
    Issue #3163628 by jrockowitz: Only add session context to webform when...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Version: 8.x-5.x-dev » 6.x-dev
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.