Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#4 | add-default-tab-styling-3163456-4.patch | 3.88 KB | behindthepage |
#3 | add-default-tab-styling-3163456-3.patch | 2.22 KB | behindthepage |
Comments
Comment #2
opdavies.
Comment #3
behindthepage CreditAttribution: behindthepage as a volunteer commentedI have recently downloaded this theme and this one of the first things I did. Patched attached for review.
Comment #4
behindthepage CreditAttribution: behindthepage as a volunteer commentedRevised patch attached with extra theming for secondary links.
Comment #5
opdaviesThanks, @behindthepage!
I've tested this out on my personal site and it looks good.
I'll double-check, but I don't think that we need the
tw-
prefix though as it should have been removed in the 4.x branch. I don't see it in https://git.drupalcode.org/project/tailwindcss/-/raw/4.x/dist/tailwind.css, for example, but I'll try it with a plain Drupal installation and see what happens.Comment #6
behindthepage CreditAttribution: behindthepage as a volunteer commentedYes, sorry I did it on the 2.7 branch.
While the tw- prefix is a bit of a pain I thought it was a good idea to differentiate the Tailwind classes from anything Drupal generated.
Have you found that not to be a problem?
Regards
Geoff
Comment #7
opdaviesI haven't found it to be an issue on my site and the ones that I've used the non-prefixed Tailwind on.
We should probably add something for responsive tabs in this issue too. This patch is a great starting point but is just adding styles for desktop as far as I can see.
Comment #8
behindthepage CreditAttribution: behindthepage as a volunteer commentedGood point.
I am not sure when I will get back to this so you might like to add this to the repo so there is at least some styling on the tabs and we can add to it later.
Comment #12
opdaviesI've added some basic list styling with the
list-disc
andlist-inside
classes as a minimal solution.Further styling can be added in a separate issue.
Comment #13
opdavies