One of the best parts of Taxonomy Manager in D7 was using it with Term Merge to combine multiple terms into one. However, that functionality isn't available in D8 yet, the integration hasn't been built yet.

Build the necessary integration so that the "merge" functionality can be used with Taxonomy Manager.

CommentFileSizeAuthor
#17 term_merge-n3160872-17.patch17.89 KBDamienMcKenna
#16 interdiff_13-16.txt1.06 KBressinel
#16 term_merge-taxonomy_manager_compatibility-3160872-16.patch17.86 KBressinel
#13 3160872-13-taxonomy_manager_compatibility.patch17.79 KBRenrhaf
#3 taxonomy_manager_integration-3160872-3.patch2.44 KBalesbencina

Issue fork term_merge-3160872

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

VladimirAus’s picture

VladimirAus
Primary language English
Location Brisbane 🇦🇺
CreditAttribution: VladimirAus at Tomato Elephant Studio commented
Priority: Normal » Major

Bumping priority to Major so we can look at it in the near furute.

alesbencina’s picture

alesbencina CreditAttribution: alesbencina as a volunteer and at Agiledrop - Your Trusted Drupal Teammates commented
FileSize
taxonomy_manager_integration-3160872-3.patch2.44 KB

hi,

I have created a patch for taxonomy manager which uses the term merge.

https://www.drupal.org/project/taxonomy_manager/issues/3220993#comment-1...

For term_merge module I've added a module handler if taxonomy_manager is enabled and changed the route name to taxonomy_manager.admin_vocabulary'.

alesbencina opened merge request !1

alesbencina closed merge request !1

alesbencina opened merge request !2

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Active » Needs review

Thanks, the pull request is pretty far and I reviewed it.

I'm not sure if the API changes are acceptable to the maintainers, leaving it at "needs review" for now.

Status: Needs review » Needs work

The last submitted patch, 3: taxonomy_manager_integration-3160872-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented

Tests are failing, can you fix the interface declaration of that dummy?

I think it would also be good to add some test coverage for the new functionality that the API works as intended.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Needs work » Needs review

Thanks, looks good to me now!

As I said leaving this in the "needs review" state for the maintainers.

mlncn’s picture

mlncn CreditAttribution: mlncn as a volunteer and at Agaric for Drutopia, Find It Cambridge, Cambridge, Massachusetts Family Policy Council commented
Status: Needs review » Reviewed & tested by the community

This is tested and working with #3220993: Option to merge terms (Term Merge integration).

(Setting to RTBC — at least for myself as a maintainer i like to see things that are reviewed and tested by the community right up front!)

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Version: 8.x-1.x-dev » 2.0.x-dev
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

This now needs to target the 2.0.x branch. The MR doesn't apply there.

Renrhaf’s picture

Renrhaf
Primary language French
Location 📍 Strasbourg 🐦🦜
CreditAttribution: Renrhaf at SaaS Production for Les Décideurs commented
Status: Needs work » Needs review
FileSize
3160872-13-taxonomy_manager_compatibility.patch17.79 KB

Rerolling patch for 2.0.x branch.

Using the old school method since I do not have the rights to modify the PR on gitlab.
Please note that was a hardcoded field name "field_term_synonyms" used in the module code which in my opinion is not acceptable, I created a new event dispatched before the merge event to let other modules modify the source terms and target term before the merge.
The code that was using this hard coded field can be put into such an event subscriber.

(See the patch on taxonomy manager side : https://www.drupal.org/project/taxonomy_manager/issues/3220993#comment-1...)

Renrhaf’s picture

Renrhaf
Primary language French
Location 📍 Strasbourg 🐦🦜
CreditAttribution: Renrhaf at SaaS Production for Les Décideurs commented
Issue tags: -Needs reroll
Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Status: Needs review » Needs work

Left a review comment. Looking really good, but still needs some work, I guess?
BTW there's activity in #3220993: Option to merge terms (Term Merge integration) again! :)

ressinel’s picture

ressinel
Location 🇺🇦 Rivne
CreditAttribution: ressinel as a volunteer commented
FileSize
term_merge-taxonomy_manager_compatibility-3160872-16.patch17.86 KB
interdiff_13-16.txt1.06 KB

Re-rolled patch #13 to make it compatible with Drupal 10.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
term_merge-n3160872-17.patch17.89 KB

The merge request needs to be updated to the 2.0.x branch.

This is a reroll to fix changes in TermMerger.php.