Change static queries to dynamic queries in core/modules/{every module}/tests

80 occurrences of query() and 7 occurrences of queryRange() found.

I am working on it.

nijolawrence -- that's a lot! do you have a list! maybe we could divide and conquer this issue

@partyka - I am sorry I didnot notice your message.

queryRange() - All 7 occurrences fixed
query() - All 67 occurrences fixed

The rest of 13 happened to be 9 Views query() and 4 xpath query().

No worries, since there’s a lot, how did you determine this list?

Fixed errors.

I have reverted one of the static queries in core/modules/system/tests/modules/error_test/src/Controller/ErrorTestController.php

  /**
   * Trigger an exception to test the PDO exception handler.
   */
  public function triggerPDOException() {
    define('SIMPLETEST_COLLECT_ERRORS', FALSE);
    $this->database->query('SELECT * FROM bananas_are_awesome');
  }

Since this is trying to trigger a PDO exception should this be improved?

@partyka I have done a grep with '>query(' and '>queryRange('.

Please let me know if I missed something.

@daffie Thanks for your feedback. I am working on making the change

Updated the patch with the change mentioned by @daffie. Also fixed the coding standard messages mentioned in the Automated Test.

1. +++ b/core/modules/jsonapi/tests/src/Functional/ResourceTestBase.php
   @@ -975,9 +975,10 @@ public function testGetIndividual() {
   +      ->select('cache_dynamic_page_cache', 'cdpc')
   +      ->fields('cdpc', ['cid', 'data'])
   

   /Users/alex/dev/drupal/core/modules/jsonapi/tests/src/Functional/ResourceTestBase.php:978:45 - Unknown word (cdpc)
   

   This triggers a spelling mistake error. If you can this to cdp then it won't - we ignore words less than 4 characters which is fine for most aliases.

2. +++ b/core/modules/system/tests/src/Functional/System/ErrorHandlerTest.php
   @@ -127,7 +127,7 @@ public function testExceptionHandler() {
   -    $this->assertText($error_pdo_exception['@message'], new FormattableMarkup('Found @message in error page.', $error_pdo_exception));
   +    $this->assertSession()->pageTextContains($error_pdo_exception['@message']);
   

   This change, whilst it looks correct, is out-of-scope

@alexpott Thanks for reviewing my changes.

1. I will make changes and upload a new patch.

2. Regarding this. The change in the static query in core/modules/system/tests/modules/error_test/src/Controller/ErrorTestController.php was causing the tests to fail.

  /**
   * Trigger an exception to test the PDO exception handler.
   */
  public function triggerPDOException() {
    define('SIMPLETEST_COLLECT_ERRORS', FALSE);
    $this->database->query('SELECT * FROM bananas_are_awesome');
  }

For fixing this I made the changes you mentioned. Please let me know how you want me to move forward with this. Should I revert changes to this file as well?

Re #15.2 ah I see we're dealing with a difference in how quotes are handled. Fun. So yeah we only need to cope with #15.1

@alexpott @daffie

Fixed #15.1.
Added comment in front of #15.2.

Please review and let me know if any other changes are required.

+++ b/core/modules/big_pipe/tests/src/Functional/BigPipeTest.php
@@ -191,10 +191,11 @@ public function testBigPipe() {
+    // database drivers the ability to insert their own limit
+    // and offset functionality.

+++ b/core/modules/system/tests/src/Functional/System/ErrorHandlerTest.php
@@ -127,7 +127,9 @@ public function testExceptionHandler() {
+    // Assert statement improved since static queries adds table alias
+    // in the error message.

Wrapped too early. Addressing and stay RTBC.

Committed 3312c7b and pushed to 9.1.x. Thanks!

Here's the backport.

The following files were in conflict:

• 'core/modules/user/tests/src/Functional/UserLoginHttpTest.php'
• 'core/modules/user/tests/src/Functional/UserLoginTest.php'

#2983395: user module's flood controls should do better logging added db queries to 9.1.x

Committed bba4be9 and pushed to 9.0.x. Thanks!

Queries are not quoted in the same way in D8.

Committed f06027d and pushed to 8.9.x. Thanks!