The D7 codebase could use a bit of a cleanup.

CommentFileSizeAuthor
#10 backup_migrate-n3158379-10.patch536 bytesDamienMcKenna
#6 backup_migrate-n3158379-6.patch74.37 KBDamienMcKenna
#3 backup_migrate-n3158379-3.patch74.33 KBDamienMcKenna
#2 backup_migrate-n3158379-2.patch62.36 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
backup_migrate-n3158379-2.patch62.36 KB

WIP, needs a little more work.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
backup_migrate-n3158379-3.patch74.33 KB

Further improvements.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: backup_migrate-n3158379-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
backup_migrate-n3158379-6.patch74.37 KB

Ah, small typoo after renaming a variable.

  • DamienMcKenna committed a6d3560 on 7.x-3.x 
    Issue #3158379 by DamienMcKenna: Coding standards improvements
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed. This isn't all of the possible improvements, but it's a good bunch.

monnerat’s picture

monnerat CreditAttribution: monnerat commented

This fails with PHP 5.5 after upgrading to 7.x-3.8:
Parse error: syntax error, unexpected '*', expecting ',' or ';' in .../drupal/modules/backup_migrate/includes/destinations.inc on line 804
Replacing
public $cache_expire = 24 * 60 * 60;
by
public $cache_expire = 86400;
fixes the problem.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Fixed » Needs review
FileSize
backup_migrate-n3158379-10.patch536 bytes

Darnit. Sorry.

I've changed one of the automated tests to check PHP 5.5 instead of 5.6.

This patch should fix it for you.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Related issues: +#3158405: Plan for Backup and Migrate 7.x-3.9

  • DamienMcKenna committed e919a8a on 7.x-3.x 
    Issue #3158379 by DamienMcKenna, monnerat: Fixed compatibility with PHP...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Related issues: +#3159270: Fixed compatibility with PHP 5.4

I've released 7.x-3.9 with this fix.

BTW I opened a new issue to fix compatibility with PHP 5.4: #3159270

monnerat’s picture

monnerat CreditAttribution: monnerat commented

7.x-3.9 works for me on PHP 5.5.
Thanks for fix.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.