Shipping methods link is in the root of the commerce menu but it should probably go under Configuration > Shipping.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rinasek created an issue. See original summary.

rinasek’s picture

Status: Active » Needs review
FileSize
513 bytes

Patch attached

  • jsacksick committed 04b1fe3 on 8.x-2.x authored by rinasek
    Issue #3156717 by rinasek: Move the 'shipping methods' link under...
jsacksick’s picture

Status: Needs review » Fixed

Committed!

bojanz’s picture

Note that this reverts #3076739: Shipping methods shouldn't be under /admin/commerce/config when they're not config fixed for 2.0-rc1. I suggest adding a comment to that issue explaining the revert.

You'll also want to make sure shipping method translation still works, I don't think we have test coverage for it.

bojanz’s picture

Status: Fixed » Needs work

Bumping status for the translation question in #5

jsacksick’s picture

Oh you're right... It should still work since we're not changing the paths... (which by the way is causing the breadcrumb to be broken).

I may have committed this too early without thinking of the side effects, it's probably safer to rollback this before the next release which is going to happen really soon and come back to this later...

  • jsacksick committed 38d1d33 on 8.x-2.x
    Revert "Issue #3156717 by rinasek: Move the 'shipping methods' link...
jsacksick’s picture

Category: Bug report » Feature request
Status: Needs work » Postponed

Postponing this until we add tests that demonstrate that the translation UI is still working (it probably can't work under config because the url becomes then too large for Drupal which only supports 9 levels/parts, and not 10).