Problem/Motivation

To run on PHP 8, we need to bump, among other things, the version of:

Also we should update our dependencies prior to 9.1.0.

Proposed resolution

Run composer update

Remaining tasks

User interface changes

N/a

API changes

N/a

Data model changes

N/a

Release notes snippet

Dependencies are updated to latest version. See ...generate lock diff at time of 9.1.0.

CommentFileSizeAuthor
#7 3156558-7.patch47.82 KBandypost
#3 3156558-3.patch45.35 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heddn created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Title: Run with later version of symfony/* for PHP 8 testing » Upgrade symfony/* for PHP 8 compatibility
Priority: Normal » Critical

Slightly retitling - we should update Symfony for 9.1.x regardless.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3156558-3.patch45.35 KB

We might as well update all our dependencies and see what happens.

$ composer-lock-diff --no-links
+---------------------------------+---------+---------+
| Production Changes              | From    | To      |
+---------------------------------+---------+---------+
| egulias/email-validator         | 2.1.17  | 2.1.18  |
| guzzlehttp/guzzle               | 6.5.4   | 6.5.5   |
| masterminds/html5               | 2.7.0   | 2.7.2   |
| symfony/console                 | v4.4.9  | v4.4.10 |
| symfony/debug                   | v4.4.9  | v4.4.10 |
| symfony/dependency-injection    | v4.4.9  | v4.4.10 |
| symfony/error-handler           | v4.4.9  | v4.4.10 |
| symfony/event-dispatcher        | v4.4.9  | v4.4.10 |
| symfony/http-foundation         | v4.4.9  | v4.4.10 |
| symfony/http-kernel             | v4.4.9  | v4.4.10 |
| symfony/mime                    | v5.1.0  | v5.1.2  |
| symfony/polyfill-ctype          | v1.17.0 | v1.17.1 |
| symfony/polyfill-iconv          | v1.17.0 | v1.17.1 |
| symfony/polyfill-intl-idn       | v1.17.0 | v1.17.1 |
| symfony/polyfill-mbstring       | v1.17.0 | v1.17.1 |
| symfony/polyfill-php73          | v1.17.0 | v1.17.1 |
| symfony/polyfill-php80          | v1.17.0 | v1.17.1 |
| symfony/process                 | v4.4.9  | v4.4.10 |
| symfony/psr-http-message-bridge | v2.0.0  | v2.0.1  |
| symfony/routing                 | v4.4.9  | v4.4.10 |
| symfony/serializer              | v4.4.9  | v4.4.10 |
| symfony/translation             | v4.4.9  | v4.4.10 |
| symfony/validator               | v4.4.9  | v4.4.10 |
| symfony/var-dumper              | v5.1.0  | v5.1.2  |
| symfony/yaml                    | v4.4.9  | v4.4.10 |
| typo3/phar-stream-wrapper       | v3.1.4  | v3.1.5  |
+---------------------------------+---------+---------+

+---------------------------------+--------+---------+
| Dev Changes                     | From   | To      |
+---------------------------------+--------+---------+
| composer/composer               | 1.10.6 | 1.10.8  |
| composer/xdebug-handler         | 1.4.1  | 1.4.2   |
| myclabs/deep-copy               | 1.9.5  | 1.10.1  |
| phpdocumentor/reflection-common | 2.1.0  | 2.2.0   |
| phpdocumentor/type-resolver     | 1.1.0  | 1.3.0   |
| phpunit/phpunit                 | 8.5.5  | 8.5.8   |
| symfony/browser-kit             | v4.4.9 | v4.4.10 |
| symfony/css-selector            | v4.4.9 | v4.4.10 |
| symfony/dom-crawler             | v4.4.9 | v4.4.10 |
| symfony/filesystem              | v4.4.9 | v4.4.10 |
| symfony/finder                  | v4.4.9 | v4.4.10 |
| symfony/lock                    | v4.4.9 | v4.4.10 |
| symfony/phpunit-bridge          | v4.4.9 | v4.4.10 |
| webmozart/assert                | 1.8.0  | 1.9.0   |
+---------------------------------+--------+---------+
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Title: Upgrade symfony/* for PHP 8 compatibility » Upgrade dependencies prior to 9.1.0
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

This looks good. After applying there are no updates available.

composer update --dry-run 
Loading composer repositories with package information
Updating dependencies (including require-dev)
Nothing to install or update
43 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

I updated the issue summary and title to work the patch.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work 
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 2 updates, 0 removals
  - Updating twig/twig (v2.12.5) to twig/twig (v2.13.0)
  - Updating masterminds/html5 (2.7.2) to masterminds/html5 (2.7.3)
44 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

And we need that twig release for PHP 8 :)

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Needs review
FileSize
3156558-7.patch47.82 KB

Fix #6

 $ composer-lock-diff --no-links
+---------------------------------+---------+---------+
| Production Changes              | From    | To      |
+---------------------------------+---------+---------+
| egulias/email-validator         | 2.1.17  | 2.1.18  |
| guzzlehttp/guzzle               | 6.5.4   | 6.5.5   |
| masterminds/html5               | 2.7.0   | 2.7.3   |
| symfony/console                 | v4.4.9  | v4.4.10 |
| symfony/debug                   | v4.4.9  | v4.4.10 |
| symfony/dependency-injection    | v4.4.9  | v4.4.10 |
| symfony/error-handler           | v4.4.9  | v4.4.10 |
| symfony/event-dispatcher        | v4.4.9  | v4.4.10 |
| symfony/http-foundation         | v4.4.9  | v4.4.10 |
| symfony/http-kernel             | v4.4.9  | v4.4.10 |
| symfony/mime                    | v5.1.0  | v5.1.2  |
| symfony/polyfill-ctype          | v1.17.0 | v1.17.1 |
| symfony/polyfill-iconv          | v1.17.0 | v1.17.1 |
| symfony/polyfill-intl-idn       | v1.17.0 | v1.17.1 |
| symfony/polyfill-mbstring       | v1.17.0 | v1.17.1 |
| symfony/polyfill-php73          | v1.17.0 | v1.17.1 |
| symfony/polyfill-php80          | v1.17.0 | v1.17.1 |
| symfony/process                 | v4.4.9  | v4.4.10 |
| symfony/psr-http-message-bridge | v2.0.0  | v2.0.1  |
| symfony/routing                 | v4.4.9  | v4.4.10 |
| symfony/serializer              | v4.4.9  | v4.4.10 |
| symfony/translation             | v4.4.9  | v4.4.10 |
| symfony/validator               | v4.4.9  | v4.4.10 |
| symfony/var-dumper              | v5.1.0  | v5.1.2  |
| symfony/yaml                    | v4.4.9  | v4.4.10 |
| twig/twig                       | v2.12.5 | v2.13.0 |
| typo3/phar-stream-wrapper       | v3.1.4  | v3.1.5  |
+---------------------------------+---------+---------+

+---------------------------------+--------+---------+
| Dev Changes                     | From   | To      |
+---------------------------------+--------+---------+
| composer/composer               | 1.10.6 | 1.10.8  |
| composer/xdebug-handler         | 1.4.1  | 1.4.2   |
| myclabs/deep-copy               | 1.9.5  | 1.10.1  |
| phpdocumentor/reflection-common | 2.1.0  | 2.2.0   |
| phpdocumentor/type-resolver     | 1.1.0  | 1.3.0   |
| phpunit/phpunit                 | 8.5.5  | 8.5.8   |
| symfony/browser-kit             | v4.4.9 | v4.4.10 |
| symfony/css-selector            | v4.4.9 | v4.4.10 |
| symfony/dom-crawler             | v4.4.9 | v4.4.10 |
| symfony/filesystem              | v4.4.9 | v4.4.10 |
| symfony/finder                  | v4.4.9 | v4.4.10 |
| symfony/lock                    | v4.4.9 | v4.4.10 |
| symfony/phpunit-bridge          | v4.4.9 | v4.4.10 |
| webmozart/assert                | 1.8.0  | 1.9.0   |
+---------------------------------+--------+---------+
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed 4d4c87e and pushed to 9.1.x. Thanks!

I guess there's a question about Drupal 8 and what we're backporting there. That gets confusing if it gets ahead of Drupal 9.0.x. So going to mark this one as fixed and we can work out what we need to do for Drupal 8 in the inevitable PHP 8 issue for Drupal 8.

  • alexpott committed 4d4c87e on 9.1.x 
    Issue #3156558 by longwave, andypost, alexpott, heddn, catch: Upgrade...
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

Filed follow-up for new releases #3157296: Upgrade dependencies prior to 9.1.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: +9.1.0 release notes