https://git.drupalcode.org/project/xmlsitemap/-/blob/63dab7ca0376abd687b...

CommentFileSizeAuthor
#10 screeshot-2020-07-02-10-36-34.png112.59 KBmxr576
#5 3156088-deprecate-link-bundle-access-bundle-path.patch6.4 KBDave Reid
#2 3156088-deprecate-link-bundle-access-bundle-path.patch6.1 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mxr576 created an issue. See original summary.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Priority: Major » Minor
FileSize
3156088-deprecate-link-bundle-access-bundle-path.patch6.1 KB

I have a feeling that this code is no longer used at all. I'll deprecate those two functions.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3156088-deprecate-link-bundle-access-bundle-path.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Needs work » Needs review
FileSize
3156088-deprecate-link-bundle-access-bundle-path.patch6.4 KB

Sigh, $entity is not an actual entity, but an entity type.

  • Dave Reid committed db623fd on 8.x-1.x 
    Issue #3156088 by Dave Reid: Deprecated xmlsitemap_link_bundle_access()...
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Status: Needs review » Fixed

Committed #5 to 8.x-1.x.

  • Dave Reid committed db623fd on 2.x 
    Issue #3156088 by Dave Reid: Deprecated xmlsitemap_link_bundle_access()...
mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
CreditAttribution: mxr576 at Pronovix commented

Thanks for the quick fix.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
CreditAttribution: mxr576 at Pronovix commented
Status: Fixed » Needs work
FileSize
screeshot-2020-07-02-10-36-34.png112.59 KB

So I had no issue with the xmlsitemap_link_bundle_access() hook, it should have just done a better callback handling, like allowing classes methods/services/functions to be passed a callback by using \Drupal\Core\DependencyInjection\ClassResolverInterface::getInstanceFromDefinition()

Now that the function is deprecated my old code should be useless that granted access to a user who has administer create/edit XY node bundle permission, BUT the committed code does not handle node bundles, the node entity itself does not have admin permission, bundles have.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented

I'd rather add a separate "can override xmlsitemap settings on items" permission, rather than adding this back in. There might be an existing issue for this? You could also form alter that #access property to TRUE with your specific logic.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
CreditAttribution: mxr576 at Pronovix commented

I do not want to alter form just to make this very simple feature be implemented. I rather like to concept of adding an "access checker services" that could decide if in the given context a user can add/chance XMLsitemap settings or not on an enitty. That service could be easily decorated by downstream devs to extend the implementation.
Granular permissions are always better and if it out of the scope of XMLSitemap to provide those granular permissions to every entity (including nodes) - I do believe it is out scope - then it should provide a simple way of extending the implementations.