Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I'd have thought most developers will now be using node 12 or later on their environments. If this is used alongside gulp 3 or less a primordials error will be seen when running gulp commands.
It looks like this projects gulp tasks will need a minimal amount of updates to get it working with gulp v4.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3155396-paragraphs-gulp-upgrade-9.patch | 269.08 KB | sasanikolic |
| |||
| #9 | 3155396-paragraphs-gulp-upgrade-interdiff-8-9.txt | 4.18 KB | sasanikolic |
| #8 | 3155396-paragraphs-gulp-upgrade-8.patch | 266.19 KB | pivica |
| |||
| #8 | 3155396-paragraphs-gulp-upgrade-interdiff-7-8.txt | 1.52 KB | pivica |
Comments
Comment #2
alanoakden CreditAttribution: alanoakden at Access commentedPatch provided
Comment #3
alanoakden CreditAttribution: alanoakden at Access commentedComment #4
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedHi @alanoakden, thanks for your contribution.
I tested your changes with node v10 and v12, but a couple of things doesn't seem to work correctly yet:
Comment #5
alanoakden CreditAttribution: alanoakden at Access commentedInteresting, which SASS file didn't compile?
I've basically just captured the changes i made to even get everything working in the first place on my local.
Comment #6
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedI tested with paragraphs.widget.scss and paragraphs.modal.scss.
Node versions v10.21.0 and v12.18.2.
Comment #7
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedDid some quick debugging and found out that options.scssSrc is defined as
"./", therefore the paths were wrong and sass and linter didn't work correctly, as the path was then".//*.scss". Not sure how this worked before... Fixed this in this patch.Comment #8
pivica CreditAttribution: pivica at MD Systems GmbH commentedTested fully latest patch including CSS compilation, works as expected and do not produce any differences in CSS.
Patch is huge because we are adding package-lock.json but it makes sense to add this so everybody are using same libraries and results are consistent.
> Not sure how this worked before...
Probably previous versions of gulp handled that differently and with latest updates this now throws error which is a correct behaviour because it is a wrong path.
Additionally changed documentation about running gulp with `npx gulp`, I guess it makes more sense because you don't need to have gulp installed globally and npx is now shipped with npm.
Comment #9
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedGot a bit carried away when reviewing the readme file, with so many grammar mistakes... :)
Let me know if you want me to create a followup for those fixes or if doing that in this patch is fine.
Comment #10
BerdirHa. Fixed typos, you mean added 10 "the"'s ;) (Yes, I counted them).
Fine with me, committed.