Problem/Motivation

There's leftover for #3086795: "Search help" link in search form is ambiguous and confusing in search module

Proposed resolution

As there's test coverage for Label, todo just needs removal

Remaining tasks

patch/review/comit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

no

CommentFileSizeAuthor
#2 3155221-2.patch1.25 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Active » Needs review
Related issues: +#3087879: Use admin theme annotation for help topics search
FileSize
3155221-2.patch1.25 KB

Credits to #3087879-32: Use admin theme annotation for help topics search

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Looks good. As noted on the other issue, that @todo is outdated because the other issue included a test for the text of the help link.

  • lauriii committed 311db38 on 9.1.x 
    Issue #3155221 by andypost, jhodgdon: Remove outdated todo and link to...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii as a volunteer and commented
Status: Reviewed & tested by the community » Fixed

Committed 311db38 and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.