Problem/Motivation

Original parent issue's scope was too broad. Breaking the patch on the parent issue into smaller child issues.

@mmatsoo had found singular/plural grammar errors in the original issue:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ju.vanderw created an issue. See original summary.

ju.vanderw’s picture

Status: Active » Needs review
FileSize
1.71 KB

Attaching patch that includes the two instances found by @mmatsoo here.

The a/an grammar errors are already included in the patch here.

kevinvhengst’s picture

Status: Needs review » Reviewed & tested by the community

Seems good.

alexpott’s picture

Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed
+++ b/core/modules/views/src/Form/ViewsExposedForm.php
@@ -101,7 +101,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
-          // When an user choose an option the selected value is split
+          // When an user chooses an option the selected value is split

It feels funny to fix this line and not fix everything else "an user" is not proper grammar either it is "a user" But a guess that's #2851394: Fix grammar 'a' to 'an' when necessary

Grammar fixes like this are hard to scope. No idea on how to automate grammar checking of comments. Let's do this one.

Committed and pushed b8eac3f203 to 9.1.x and a91627dd66 to 9.0.x and 8e2dbf005b to 8.9.x. Thanks!

Backported to 8.9.x since these are docs fixes.

  • alexpott committed b8eac3f on 9.1.x
    Issue #3154914 by ju.vanderw: Fix grammar usage of singular/plural
    

  • alexpott committed a91627d on 9.0.x
    Issue #3154914 by ju.vanderw: Fix grammar usage of singular/plural
    
    (...

  • alexpott committed 8e2dbf0 on 8.9.x
    Issue #3154914 by ju.vanderw: Fix grammar usage of singular/plural
    
    (...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.