Problem/Motivation

As title

Proposed resolution

Example:

-    $this->assertTrue(is_array($component));
+    $this->assertIsArray($component);
CommentFileSizeAuthor
#2 feeds-is-array-3154457.patch3.41 KBnovchuk.v
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

novchuk.v created an issue. See original summary.

novchuk.v’s picture

novchuk.v CreditAttribution: novchuk.v commented
Assigned: novchuk.v » Unassigned
Status: Active » Needs review
FileSize
feeds-is-array-3154457.patch3.41 KB
jamesdixon’s picture

jamesdixon CreditAttribution: jamesdixon at Dialed In Design commented

Ah cool update to the tests thanks.

@megachriz think we should commit this?

  • MegaChriz committed cb2ecae on 8.x-3.x authored by novchuk.v 
    Issue #3154457 by novchuk.v: Replaced assertions involving calls to...
MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
Status: Needs review » Fixed

@jamesdixon
Yes. Previously assertIsArray() wasn't available in Drupal 8.8. I even had a hand in it being backported eventually (see #3126787-33: [D8 only] Add forwards-compatibility shim for assertInternalType() replacements in phpunit 6&7).

Committed #2. Thanks for contributing, @novchuk.v!

jamesdixon’s picture

jamesdixon CreditAttribution: jamesdixon at Dialed In Design commented

Awesome thanks both!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.