Problem/Motivation

We committed the #2972224: Add .cspell.json to automate spellchecking in Drupal core yesterday which is great but unfortunately we'd introduced 2 spelling mistakes into core whilst that patch was at rtbc.

#2908079: Move some of the bootstrap.inc PHP-related constants to \Drupal and deprecate the old versions introduced whitescreen - which should be "white screen" - we already have an instance of that in core
and #2983395: user module's flood controls should do better logging introduced a service called "user.flood_subcriber"

As there is a misspelt service name in 9.1.x I've made this issue major as we have not released 9.1.x yet fixing this now without a deprecation is fine.

Proposed resolution

Fix the spellings.

Remaining tasks

None

User interface changes

None

API changes

None - the service is an event subscriber so it shouldn't really be a dependency of anything.

Data model changes

None

Release notes snippet

N/a

CommentFileSizeAuthor
#2 3153790-2.patch1.17 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Active » Needs review
FileSize
3153790-2.patch1.17 KB
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/modules/user/user.services.yml
@@ -62,7 +62,7 @@ services:
+  user.flood_subscriber:

glad we got it before its out :)

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented 
  1. +++ b/core/install.php
@@ -22,7 +22,7 @@
+// helpful error message rather than a white screen from any fatal errors due to

    As the typo whitescreen was spotted by @alexpott who is a native English speaker, and it's in the comment, so it's good to me.

  2. +++ b/core/modules/user/user.services.yml
@@ -62,7 +62,7 @@ services:
-  user.flood_subcriber:
+  user.flood_subscriber:

    Confirmed this is a newly added service committed on June 9th, https://git.drupalcode.org/project/drupal/commit/9461f4a, but no new release since 3rd June, when 9.0.0 was released. So as @alexpott pointed "fixing this now without a deprecation is fine."

So if testing passes, this is RTBC to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented 
<p>{% trans %}Under some situations, your site can generate error messages. These can be due to user errors (such as entering invalid values in a form, or incorrect configuration), PHP runtime errors, or software bugs. Some errors may result in a <em>white screen of death</em> (a totally blank web page response); less drastic errors will generate error messages. You can configure what happens when an error message is generated.{% endtrans %}</p>

From core/modules/help_topics/help_topics/system.config_error.html.twig - is the existing use of white screen... plus searching on google for whitescreen redirects to "white screen"

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented

In fact, the typo was introduced by me per @xjm's comment https://www.drupal.org/project/drupal/issues/2908079#comment-13593641, as she is a native English speaker, that's why I did not take it as a typo even Grammarly did spot it for me as I could remember.

  • catch committed 05e2634 on 9.1.x 
    Issue #3153790 by alexpott, jungle, vijaycs85: Fix spelling errors in...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.1.x, thanks!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Title: Fix spelling errors in core » Fix spelling errors in mis-named service and an unrelated comment

The title of this issue is a lot broader than what it's actually doing.

Are there no tests for user.flood_subscriber?

Also, there's a case to be made that "whitescreen" should instead be in the dictionary since this we are basically watching a compound word form in language for a Drupal developer conflict. (In the same way that "unserialize" is detected as a spelling error, but is obviously a programming term and acceptable as spelled.)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

As an event subscriber the service is never accessed by its name. It's the event subscriber tag that matters. Yes there are tests for the event - see core/modules/user/tests/src/Functional/UserLoginTest.php for example.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.